Merge ~bladernr/plainbox-provider-resource:1711237-enumerator-always-pass into plainbox-provider-resource:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: 62829a56f040db621ba4477e0c7bee4148829d75
Merged at revision: 1e374d2259293be62f52ec6d731a541a7eabe03a
Proposed branch: ~bladernr/plainbox-provider-resource:1711237-enumerator-always-pass
Merge into: plainbox-provider-resource:master
Diff against target: 12 lines (+1/-0)
1 file modified
jobs/resource.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Maciej Kisielewski Approve
Review via email: mp+329155@code.launchpad.net

Description of the change

simple fix to ensure that executable always passes, even when it complains about $PATH having non-existent directories.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

+1!

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[trusty] starting container
[trusty] (timing) 0.05user 0.02system 0:05.23elapsed 1%CPU (0avgtext+0avgdata 17120maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+5611minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: https://paste.ubuntu.com/25369904/
[trusty] stderr: https://paste.ubuntu.com/25369905/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources
Destroyed container trusty-testing
[xenial] starting container
[xenial] (timing) 0.07user 0.02system 0:04.23elapsed 2%CPU (0avgtext+0avgdata 17208maxresident)k
[xenial] (timing) 0inputs+32outputs (0major+5454minor)pagefaults 0swaps
[xenial] provisioning container
[xenial] (timing) 20.37user 4.49system 2:32.48elapsed 16%CPU (0avgtext+0avgdata 79996maxresident)k
[xenial] (timing) 8inputs+1182040outputs (0major+816051minor)pagefaults 0swaps
[xenial-testing] Starting tests...
Found a test script: ./requirements/container-tests-provider-resource-generic
[xenial-testing] container-tests-provider-resource-generic: FAIL
[xenial-testing] stdout: https://paste.ubuntu.com/25369916/
[xenial-testing] stderr: https://paste.ubuntu.com/25369917/
[xenial-testing] (timing) Command exited with non-zero status 1
[xenial-testing] (timing) 5.54user 0.72system 0:12.07elapsed 51%CPU (0avgtext+0avgdata 75520maxresident)k
[xenial-testing] (timing) 0inputs+99384outputs (0major+77666minor)pagefaults 0swaps
[xenial-testing] Fixing file permissions in source directory
[xenial-testing] Destroying container
Name: xenial-testing
State: STOPPED

review: Needs Fixing
Revision history for this message
Jeff Lane  (bladernr) wrote :

fixed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/resource.pxu b/jobs/resource.pxu
2index 8ee7701..9598aad 100644
3--- a/jobs/resource.pxu
4+++ b/jobs/resource.pxu
5@@ -118,6 +118,7 @@ _summary: Enumerate available system executables
6 _description: Generates a resource for all available executables
7 command:
8 find -H $(echo "$PATH" | sed -e 's/:/ /g') -maxdepth 1 -xtype f -executable -printf "name: %f\nlocation: %h\n\n"
9+ true
10
11 id: device
12 estimated_duration: 0.48

Subscribers

People subscribed via source and target branches