Merge ~bladernr/plainbox-provider-resource:1705745-dmi-supported-resource into plainbox-provider-resource:master

[Jeff Lane ]

Adds a 'supported' item to the dmi resource to indicate that the SUT supports DMI (verified by the presense of /sys/devices/virtual/dmi).

Jobs using this can now say:

requires: dmi.supported == 'True'

Example result from a supported case:

Test DMI data for CPUs passed unspecified 1

Base Board Information:
Chassis Information:
Processor Information:
 Version: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
System Information:
Passed all tests

And example where supported is False (simulated by changing the requires from True to False):

Test DMI data for CPUs not supported unspecified 1 job cannot be started: resource expression "dmi.supported == 'False'" evaluates to false

[Jeff Lane  (bladernr)]

This could (maybe should) replace the arch specific requirements so that DMI jobs will now run on anything that has the dmi directories present, indicating support for dmi.

[Rod Smith (rodsmith)]

I've tested this on a couple of systems, tweaking the filename to simulate the non-presence of /sys/devices/virtual/dmi, and it worked as expected. (I also had to change some job definitions to use this modified test rather than check architecture type.)

review: Approve

[Jeff Lane  (bladernr)]

Also... tested the script itself on a Z instance (no dmi there):

ubuntu@hwe0008:~$ ls /sys/devices/virtual/
bdi block iscsi_transport mem misc net tty workqueue
ubuntu@hwe0008:~$ sudo ./dmi_resource
supported: False

it properly returns supported: False

[Jonathan Cave (jocave)]

I don't like the way this particular solution combines the test for dmi support and the production of dmi resource entries in to one job.

Currently all records produced by the dmi job are individual entries in the system dmi table, with this addition one record is "special" and indicates platform support e.g.:

--------------[ Running job 2 / 2. Estimated time left: 0:00:01 ]---------------
--------------[ Collect information about hardware devices (DMI) ]--------------
ID: com.canonical.certification::dmi
Category: com.canonical.plainbox::uncategorised
... 8< -------------------------------------------------------------------------
supported: True

path: /devices/virtual/dmi/id/bios
category: BIOS
product: 00.00.27
vendor: Dell Inc.
version: 00.00.27

path: /devices/virtual/dmi/id/system
category: SYSTEM
product: Edge Gateway 3003
vendor: Dell Inc.
serial: 9D5JB02

path: /devices/virtual/dmi/id/board
category: BOARD
product: 0ffnwn
vendor: Dell Inc.
serial: /9D5JB02/cn7443171a002b/
version: x02
------------------------------------------------------------------------

I would prefer to see an extra job that does the test and can be used in the requires field.

review: Needs Fixing

[Jeff Lane  (bladernr)]

This was already approved and merged. I've instead created a new MR to refactor this:

https://code.launchpad.net/~bladernr/plainbox-provider-resource/+git/plainbox-provider-resource/+merge/328047

diff --git a/bin/dmi_resource b/bin/dmi_resource
index 4100727..ac2879b 100755
--- a/bin/dmi_resource
+++ b/bin/dmi_resource
@@ -42,12 +42,19 @@ class DmiResult:
 
 
 def main():
-    stream = os.popen(COMMAND)
-    dmi = DmidecodeParser(stream)
 
-    result = DmiResult()
-    dmi.run(result)
+    if os.path.exists('/sys/devices/virtual/dmi'):
+        print("supported: True")
+        print()
+
+        stream = os.popen(COMMAND)
+        dmi = DmidecodeParser(stream)
 
+        result = DmiResult()
+        dmi.run(result)
+    else:
+        print("supported: False")
+        print()
     return 0