Merge ~bladernr/plainbox-provider-checkbox:1904965-cooper-lake-cpuid into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: 669c74e978d84d62499e00e39b3956d3bcd3133c
Merged at revision: 7748fd527657de4b90aedb738191e9500ec0be48
Proposed branch: ~bladernr/plainbox-provider-checkbox:1904965-cooper-lake-cpuid
Merge into: plainbox-provider-checkbox:master
Diff against target: 19 lines (+2/-0)
1 file modified
bin/cpuid.py (+2/-0)
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Devices Certification Bot Needs Fixing
Jonathan Cave (community) Needs Fixing
Review via email: mp+394225@code.launchpad.net

Commit message

bin/cpuid.py: add Cooper Lake CPUID to table

Description of the change

bin/cpuid.py: add Cooper Lake CPUID to table

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Looks like a comma is missing

review: Needs Fixing
Revision history for this message
Jeff Lane  (bladernr) wrote :

Whoops!

Thanks, I fixed it.

review: Needs Resubmitting
Revision history for this message
Jeff Lane  (bladernr) wrote :

Self-approve

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [00:56:17] starting container
[bionic] [00:56:18] starting container
[focal] [00:56:20] starting container
Device project added to xenial-testing
Device project added to bionic-testing
Device project added to focal-testing
[xenial] [00:56:29] provisioning container
[bionic] [00:56:36] provisioning container
[focal] [00:56:37] provisioning container
[xenial] [00:56:43] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [00:56:58] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[focal] [00:57:27] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [00:58:36] container-tests-provider-checkbox: FAIL
[xenial] output: https://paste.ubuntu.com/p/jhHfkzzJnZ/
[xenial] [00:58:39] Fixing file permissions in source directory
[xenial] [00:58:40] Destroying container
[bionic] [00:58:52] container-tests-provider-checkbox: FAIL
[bionic] output: https://paste.ubuntu.com/p/gFbqTqRtZw/
[bionic] [00:58:55] Fixing file permissions in source directory
[bionic] [00:58:55] Destroying container
[focal] [00:59:10] container-tests-provider-checkbox: FAIL
[focal] output: https://paste.ubuntu.com/p/hc7HwRrPQt/
[focal] [00:59:13] Fixing file permissions in source directory
[focal] [00:59:13] Destroying container

review: Needs Fixing
Revision history for this message
Jeff Lane  (bladernr) wrote :

why is flake8 complaining?
bladernr@galactica:~/development/plainbox-provider-checkbox/bin$ flake8 cpuid.py ; echo $?
0
bladernr@galactica:~/development/plainbox-provider-checkbox/bin$

Revision history for this message
Jeff Lane  (bladernr) wrote :

self-approve lets try this again.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/cpuid.py b/bin/cpuid.py
2index 36d5b46..3eebf1e 100755
3--- a/bin/cpuid.py
4+++ b/bin/cpuid.py
5@@ -88,12 +88,14 @@ CPUIDS = {
6 "AMD EPYC": ['0x800f12'],
7 "AMD Lisbon": ['0x100f81'],
8 "AMD Magny-Cours": ['0x100f91'],
9+ "AMD Milan": ['0xa00f11'],
10 "AMD ROME": ['0x830f10'],
11 "Broadwell": ['0x4067', '0x306d4', '0x5066', '0x406f'],
12 "Canon Lake": ['0x6066'],
13 "Cascade Lake": ['0x50655', '0x50656', '0x50657'],
14 "Coffee Lake": [
15 '0x806ea', '0x906ea', '0x906eb', '0x906ec', '0x906ed'],
16+ "Cooper Lake": ['0x5065a', '0x5065b'],
17 "Haswell": ['0x306c', '0x4065', '0x4066', '0x306f'],
18 "Ice Lake": ['0x706e'],
19 "Ivy Bridge": ['0x306a', '0x306e'],

Subscribers

People subscribed via source and target branches