Merge ~bladernr/plainbox-provider-checkbox:1892786-add-maas-user-check into plainbox-provider-checkbox:master

[Jeff Lane ]

Added job to check BMC accounts for the maas user created during enlistment and commissioning. lp:1892786

[Jonathan Cave (jocave)]

Merges to this provider are now tested against shellcheck among other things. To run the tests locally you can use the command `./manage.py test` much like you would run `./manage.py validate`.

There are a couple of failures in this inline command:

test_job_command_units/miscellanea/jobs.pxu:475-496_miscellanea/maas_user_check (plainbox.provider_manager.InlineShellcheckTests) ...
In - line 2:
FOUND="false"
^---^ SC2034: FOUND appears unused. Verify use (or export if used externally).

In - line 7:
 let "CHAN+=1"
 ^----------^ SC2219: Instead of 'let expr', prefer (( expr )) .

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- FOUND appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2219 -- Instead of 'let expr', prefer (( ...
FAIL

review: Needs Fixing

[Jeff Lane  (bladernr)]

I've fixed all that, but when I run manage.py I don't get useful
information, I get confusing tracebacks. Note, this job runs just
fine, it's manage.py that's not working here. I've tested it on a
couple different servers to be sure it actually does what I expect it
to.

bladernr@galactica:~/development/plainbox-provider-checkbox$
./manage.py validate
warning: units/audio/manifest.pxu:19: manifest entry
'has_audio_loopback_connector', field 'prompt', field should be marked
as translatable
warning: units/gpio/manifest.pxu:3: manifest entry 'gpio_loopback',
field 'prompt', field should be marked as translatable
warning: units/image/jobs.pxu:6: job
'image/kernel-publisher-canonical', field 'description', field should
be marked as translatable
warning: units/image/jobs.pxu:4: job
'image/kernel-publisher-canonical', field 'summary', field should be
marked as translatable
warning: units/image/jobs.pxu:18: job 'image/kernel-tracking-stable',
field 'description', field should be marked as translatable
warning: units/image/jobs.pxu:16: job 'image/kernel-tracking-stable',
field 'summary', field should be marked as translatable
warning: units/image/jobs.pxu:30: job
'image/gadget-publisher-canonical', field 'description', field should
be marked as translatable
warning: units/image/jobs.pxu:28: job
'image/gadget-publisher-canonical', field 'summary', field should be
marked as translatable
warning: units/image/jobs.pxu:42: job 'image/gadget-tracking-stable',
field 'description', field should be marked as translatable
warning: units/image/jobs.pxu:40: job 'image/gadget-tracking-stable',
field 'summary', field should be marked as translatable
warning: units/image/jobs.pxu:54: job
'image/model-authority-canonical', field 'description', field should
be marked as translatable
warning: units/image/jobs.pxu:52: job
'image/model-authority-canonical', field 'summary', field should be
marked as translatable
warning: units/image/jobs.pxu:66: job 'image/model-brand-canonical',
field 'description', field should be marked as translatable
warning: units/image/jobs.pxu:64: job 'image/model-brand-canonical',
field 'summary', field should be marked as translatable
warning: units/image/test-plan.pxu:4: test plan 'iot-cert-image-full',
field 'name', field should be marked as translatable
warning: units/image/test-plan.pxu:12: test plan
'iot-cert-image-automated', field 'name', field should be marked as
translatable
warning: units/image/test-plan.pxu:18: test plan
'iot-cert-image-manual', field 'name', field should be marked as
translatable
CRITICAL plainbox.crashes: Executable 'manage.py' invoked with
Namespace(command=<plainbox.provider_manager.ValidateCommand object at
0x7f960fd23128>, debug_console=False, debug_interrupt=False,
deprecated=False, log_level=None, new_validation_core=True, pdb=False,
strict=False, trace=[]) has crashed
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/plainbox/impl/clitools.py",
line 560, in dispatch_and_catch_exceptions
    return self.dispatch_command(ns)
  File "/usr/lib/python3/dist-packages/plainbox/impl/clitools.py",
line 556, in dispatch_command
    return ns.command.invoked(ns)
  File "/usr/lib/python3/dist-p...

[Jonathan Cave (jocave)]

Checked that both the test and validate args work on my machine now. PMR should be happy. +1, thanks

review: Approve

diff --git a/units/miscellanea/jobs.pxu b/units/miscellanea/jobs.pxu
index 45015d2..5d51176 100644
--- a/units/miscellanea/jobs.pxu
+++ b/units/miscellanea/jobs.pxu
@@ -471,3 +471,25 @@ requires: package.name == 'debsums'
 command: debsums -c
 _summary: Check the MD5 sums of installed Debian packages
 _description: Verify installed Debian package files against MD5 checksum lists from /var/lib/dpkg/info/*.md5sums.
+
+plugin: shell
+category_id: com.canonical.plainbox::miscellanea
+id: miscellanea/maas_user_check
+requires:
+ executable.name == 'ipmitool'
+ cpuinfo.platform != 's390x'
+estimated_duration: 0.5
+user: root
+command:
+ CHAN=0
+ while [ $CHAN -le 15 ]; do
+  if ipmitool user list $CHAN 2>/dev/null |grep -E "maas.*ADMINISTRATOR"; then
+   break
+  fi
+  (( CHAN+=1 ))
+ done
+_description:
+ This will verify that the maas user was successfully created with admin
+ privileges
+_summary:
+ Verify BMC user called 'maas' was successfully created
diff --git a/units/miscellanea/test-plan.pxu b/units/miscellanea/test-plan.pxu
index e40dbaf..6c2d582 100644
--- a/units/miscellanea/test-plan.pxu
+++ b/units/miscellanea/test-plan.pxu
@@ -63,6 +63,7 @@ mandatory_include:
     miscellanea/cpuid
     miscellanea/get_make_and_model
     miscellanea/get_maas_version               certification-status=blocker
+    miscellanea/maas_user_check
     miscellanea/efi_boot_mode                  certification-status=blocker
     miscellanea/secure_boot_mode
     miscellanea/reboot_firmware
@@ -93,4 +94,5 @@ mandatory_include:
     miscellanea/ipmi_test                      certification-status=blocker
     miscellanea/bmc_info
     miscellanea/dmitest_server
+    miscellanea/maas_user_check
 include: