Merge ~bladernr/plainbox-provider-checkbox:1865521-add-nvdimm-health-check into plainbox-provider-checkbox:master

[Jeff Lane ]

Adds a new NVDIMM category and jobs for testing NVDIMMs

Adds a new NVDIMM category and jobs for testing NVDIMMs

[Jonathan Cave (jocave)]

From what I can see the new package is only available in Eoan and later which will probably cause some packaging issues. Either a dummy package will need to be created in the ppa (and the test prevented from running on older releases) or the package backported.

Will mark as Needs Information as the above needs working out.

review: Needs Information

[Jeff Lane  (bladernr)]

actually, I've already built/mirrored this for Bionic ;)

I'm also working on an actual SRU of the official build into Bionic from Eoan, but for now, the binaries do exist in both dev and stable PPAs.

[Jonathan Cave (jocave)]

Wonderful! I should have checked the ppa too, sorry for not doing that.

review: Approve

[Jeff Lane  (bladernr)]

After a chat with Jonathan and Sylvain, the best way to ensure this doesn't break Xenial installs is to build a dummy package for ipmctl for Xenial so that the packaging metadata doesn't break Xenial installs.

[Jeff Lane  (bladernr)]

I'll wait until that package is built and then I'll mark this as approve.

[Sylvain Pineau (sylvain-pineau)]

Dummy package available for xenial:

https://launchpad.net/~checkbox-dev/+archive/ubuntu/ppa/+packages?field.name_filter=ipmctl&field.status_filter=published

review: Approve

[Jeff Lane  (bladernr)]

Merci!

[Devices Certification Bot (ce-certification-qa)]

The merge was fine but running tests failed.

[xenial] [15:06:14] starting container
Device project added to xenial-testing
[bionic] [15:06:18] starting container
Device project added to bionic-testing
[xenial] [15:06:24] provisioning container
[bionic] [15:06:34] provisioning container
[xenial] [15:06:46] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [15:06:50] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [15:08:04] container-tests-provider-checkbox: FAIL
[xenial] [15:08:07] container-tests-provider-checkbox: FAIL
[bionic] output: https://paste.ubuntu.com/p/jCQpBZgWHS/
[bionic] [15:08:07] Fixing file permissions in source directory
[bionic] [15:08:07] Destroying container
[xenial] output: https://paste.ubuntu.com/p/gqdJdx9z9q/
[xenial] [15:08:10] Fixing file permissions in source directory
[xenial] [15:08:10] Destroying container

review: Needs Fixing

[Jeff Lane  (bladernr)]

Trying again after applying corrections

review: Approve

diff --git a/units/nvdimm/category.pxu b/units/nvdimm/category.pxu
new file mode 100644
index 0000000..84d724e
--- /dev/null
+++ b/units/nvdimm/category.pxu
@@ -0,0 +1,3 @@
+unit: category
+id: nvdimm
+_name: NVDIMM device tests
diff --git a/units/nvdimm/jobs.pxu b/units/nvdimm/jobs.pxu
new file mode 100644
index 0000000..6db1b66
--- /dev/null
+++ b/units/nvdimm/jobs.pxu
@@ -0,0 +1,27 @@
+plugin: shell
+category_id: com.canonical.certification::nvdimm
+id: nvdimm/info
+estimated_duration: 1.0  
+user: root
+requires: 
+ executable.name == "ipmctl"
+ lsb.release >= "18.04"
+command: ipmctl show -dimm
+_summary:
+ Verify that NVDIMMs are discovered
+_description:
+ This test will probe any installed NVDIMMs and list them and their capacities.
+
+plugin: shell
+category_id: com.canonical.certification::nvdimm
+id: nvdimm/health
+estimated_duration: 1.0
+user: root
+requires: 
+ executable.name == "ipmctl"
+ lsb.release >= "18.04"
+command: ipmctl show -d CurrentValue,CurrentState -sensor Health
+_summary:
+ Report health state of installed NVDIMM devices
+_description:
+ This test will do a quick health check of installed NVDIMM devices.
diff --git a/units/nvdimm/packaging.pxu b/units/nvdimm/packaging.pxu
new file mode 100644
index 0000000..fe9cfb2
--- /dev/null
+++ b/units/nvdimm/packaging.pxu
@@ -0,0 +1,4 @@
+# nvdimms require ipmctl for health check jobs
+unit: packaging meta-data
+os-id: debian
+Depends: ipmctl
diff --git a/units/nvdimm/test-plan.pxu b/units/nvdimm/test-plan.pxu
new file mode 100644
index 0000000..9951039
--- /dev/null
+++ b/units/nvdimm/test-plan.pxu
@@ -0,0 +1,7 @@
+id: nvdimm-full
+unit: test plan
+_name: NVDIM Specific Tests
+_description: NVDIMM related tests
+include:
+ nvidmm/info
+ nvdimm/health