Merge ~bladernr/plainbox-provider-checkbox:1853877-fix-scaling-test-bug into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3d0451ab8d6c12a2acc30900bac6440f1c0c4c87
Merged at revision: a5e554634708f0167076c967698c522d631e29f0
Proposed branch: ~bladernr/plainbox-provider-checkbox:1853877-fix-scaling-test-bug
Merge into: plainbox-provider-checkbox:master
Diff against target: 15 lines (+3/-1)
1 file modified
units/cpu/jobs.pxu (+3/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+375983@code.launchpad.net

Commit message

modify cpu/scaling test to use new cpuinfo.governors resource and skip execution on systems that don't support the userspace governor.

Description of the change

modify cpu/scaling test to use new cpuinfo.governors resource and skip execution on systems that don't support the userspace governor.

Tested here:
Test case skipped because requirements not met:
https://certification.canonical.com/hardware/201911-27508/submission/155018/

Test case executed because requirements were met:
https://certification.canonical.com/hardware/201911-27508/submission/155020/

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/cpu/jobs.pxu b/units/cpu/jobs.pxu
2index a027aa9..6ccc3fe 100644
3--- a/units/cpu/jobs.pxu
4+++ b/units/cpu/jobs.pxu
5@@ -2,7 +2,9 @@ plugin: shell
6 category_id: com.canonical.plainbox::cpu
7 id: cpu/scaling_test
8 estimated_duration: 150.0
9-requires: executable.name == 'fwts'
10+requires:
11+ executable.name == 'fwts'
12+ 'performance' in cpuinfo.governors
13 user: root
14 environ: PLAINBOX_SESSION_SHARE LD_LIBRARY_PATH SNAP
15 command:

Subscribers

People subscribed via source and target branches