Merge ~bladernr/plainbox-provider-checkbox:1801963-server-fwts-jobs into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: ec9d092738691513a4217d352537add4013e4256
Merged at revision: b2cdb6a6ef56c709014f68f94d6c3eb8bd537ccc
Proposed branch: ~bladernr/plainbox-provider-checkbox:1801963-server-fwts-jobs
Merge into: plainbox-provider-checkbox:master
Diff against target: 47 lines (+33/-0)
2 files modified
units/firmware/jobs.pxu (+22/-0)
units/firmware/test-plan.pxu (+11/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+358408@code.launchpad.net

Description of the change

Adds jobs to run selected fwts tests for server cert.
Adds a new test plan to units/firmware to provide nested test-plans

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks clean! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/firmware/jobs.pxu b/units/firmware/jobs.pxu
2index 5c8dcee..4dae484 100644
3--- a/units/firmware/jobs.pxu
4+++ b/units/firmware/jobs.pxu
5@@ -74,3 +74,25 @@ user: root
6 estimated_duration: 0.5
7 command: ! sudo grep -r "_REV" /sys/firmware/acpi/tables/* | grep [DS]SDT
8 _description: This Automated test checks misuse of the _REV interface in ACPI DSDT and SSDT tables
9+
10+plugin:shell
11+category_id: com.canonical.plainbox::firmware
12+id: firmware/fwts_server
13+estimated_duration: 10.0
14+requires: executable.name == 'fwts'
15+user: root
16+_description:
17+ Run Firmware Test Suite (fwts) Server Cert selected tests.
18+_summary: Run FWTS Server Cert selected tests.
19+environ: PLAINBOX_SESSION_SHARE
20+command:
21+ checkbox-support-fwts_test --server -q -l $PLAINBOX_SESSION_SHARE/fwts_server_results.log
22+
23+plugin: attachment
24+category_id: com.canonical.plainbox::firmware
25+estimated_duration: 0.5
26+id: firmware/fwts_server_results.log.gz
27+command:
28+ [ -f $PLAINBOX_SESSION_SHARE/fwts_server_results.log ] && gzip -c $PLAINBOX_SESSION_SHARE/fwts_server_results.log
29+_description: Attaches the FWTS Server Cert results log to the submission
30+_summary: Attach FWTS Server Cert test log to submission
31diff --git a/units/firmware/test-plan.pxu b/units/firmware/test-plan.pxu
32new file mode 100644
33index 0000000..62b4e05
34--- /dev/null
35+++ b/units/firmware/test-plan.pxu
36@@ -0,0 +1,11 @@
37+id: server-firmware
38+unit: test plan
39+_name: Server Firmware Tests
40+_description:
41+ Server Focused Firmware Tests
42+mandatory_include:
43+ firmware/fwts_server
44+ firmware/fwts_results.log.gz
45+include:
46+bootstrap_include:
47+ fwts

Subscribers

People subscribed via source and target branches