Merge ~bladernr/plainbox-provider-checkbox:1794926-ipmi-user-list-channels into plainbox-provider-checkbox:master

[Jeff Lane ]

Fixes problem in ipmi_test where some systems use a different channel than 0.

[Rod Smith (rodsmith)]

This works on about half a dozen systems that failed this test in 16.04.5 regression testing; however, there is one glitch -- see my inline comment.

review: Needs Fixing

[Jeff Lane  (bladernr)]

Oh ... HAHAHAHA... crap. Rookie error. I spit out the message before
actually updating the variable... sigh...

One sec, I'll fix that and push an update.
On Fri, Sep 28, 2018 at 2:35 PM Rod Smith <email address hidden> wrote:
>
> Review: Needs Fixing
>
> This works on about half a dozen systems that failed this test in 16.04.5 regression testing; however, there is one glitch -- see my inline comment.
>
> Diff comments:
>
> > diff --git a/bin/ipmi_test b/bin/ipmi_test
> > index 71e7f36..59d7aac 100755
> > --- a/bin/ipmi_test
> > +++ b/bin/ipmi_test
> > @@ -28,10 +28,27 @@ done
> > echo
> > echo "Checking for chassis status"
> > ipmitool chassis status && echo "Successfully got chassis status" && chassis=0 || chassis=1
> > +
> > echo "Checking to see if we can get power status"
> > ipmitool power status && echo "Successfully got power status" && power=0 || power=1
> > +
> > echo "Checking to see if we can get user data"
> > -ipmitool user list && echo "Successfully got user data" && user=0 || user=1
> > +# LP:1794926 Find the active channel. blindly calling user list sometimes
> > +# fails.
> > +channel=99
> > +for x in 0 1 2 3 4 5 6 7 8 9 10 11 14 15; do
> > + if ipmitool channel getaccess $x 2>1 >/dev/null; then
> > + echo "Channel in use appears to be $channel"
> > + channel=$x
>
> There's something wrong around here. With every run, I get a claim that the channel in use is 99:
>
> Checking to see if we can get user data
> Channel in use appears to be 99
> ID Name Callin Link Auth IPMI Msg Channel Priv Limit
> 1 false false true ADMINISTRATOR
>
> This happens on every system I've tested (about half a dozen). Most of these actually use channel 1.
>
> > + break
> > + fi
> > +done
> > +if [ $channel -lt 99 ]; then
> > + ipmitool user list $channel && echo "Successfully got user data" && user=0 || user=1
> > +else
> > + user=1
> > +fi
> > +
> > echo "Checking to see if we can get info on the BMC"
> > ipmitool bmc info && echo "Successfully got BMC information" && bmc=0 || bmc=1
> >
>
>
> --
> https://code.launchpad.net/~bladernr/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/355862
> You are the owner of ~bladernr/plainbox-provider-checkbox:1794926-ipmi-user-list-channels.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: bladernr
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~bladernr/plainbox-provider-checkbox/+git/plainbox-provider-checkbox:1794926-ipmi-user-list-channels
> Launchpad-Project: plainbox-provider-checkbox

--
Jeff Lane
Technical Partnership and Server Certification Programmes

"Entropy isn't what it used to be."

[Jeff Lane  (bladernr)]

Clicked the wrong thigns.. sigh... ok fixed the issue, thanks for catching that. I added that when removing the debug output I had while testing it, and simply placed it in the wrong location :/

review: Needs Resubmitting

[Rod Smith (rodsmith)]

OK, it's working now.

review: Approve

diff --git a/bin/ipmi_test b/bin/ipmi_test
index 71e7f36..12ca42c 100755
--- a/bin/ipmi_test
+++ b/bin/ipmi_test
@@ -28,10 +28,27 @@ done
 echo
 echo "Checking for chassis status"
 ipmitool chassis status && echo "Successfully got chassis status" && chassis=0 || chassis=1
+
 echo "Checking to see if we can get power status"
 ipmitool power status && echo "Successfully got power status" && power=0 || power=1
+
 echo "Checking to see if we can get user data"
-ipmitool user list && echo "Successfully got user data" && user=0 || user=1
+# LP:1794926 Find the active channel. blindly calling user list sometimes
+# fails.
+channel=99
+for x in 0 1 2 3 4 5 6 7 8 9 10 11 14 15; do
+    if ipmitool channel getaccess $x 2>1 >/dev/null; then
+        channel=$x
+        echo "Channel in use appears to be $channel"
+        break
+    fi
+done
+if [ $channel -lt 99 ]; then
+    ipmitool user list $channel && echo "Successfully got user data" && user=0 || user=1
+else
+    user=1
+fi
+
 echo "Checking to see if we can get info on the BMC"
 ipmitool bmc info && echo "Successfully got BMC information" && bmc=0 || bmc=1