Checkbox Provider - Base

Merge ~bladernr/plainbox-provider-checkbox:1760632-drop-version-checks-dmitest into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bladernr/plainbox-provider-checkbox
  3. 1760632-drop-version-checks-dmitest
  4. Merge into master
Proposed by Jeff Lane 
Status: Merged
Approved by: Rod Smith
Approved revision: 2b8d87888445740f4b96e39276f9eaecd0a49e46
Merged at revision: 77faa802b5d1ef8f8ec025d524517e1353ab212f
Proposed branch: ~bladernr/plainbox-provider-checkbox:1760632-drop-version-checks-dmitest
Merge into: plainbox-provider-checkbox:master
Diff against target: 13 lines (+1/-1)
1 file modified
units/miscellanea/jobs.pxu (+1/-1)
Reviewer Review Type Date Requested Status
Rod Smith Approve
Review via email: mp+345443@code.launchpad.net

Description of the change

Drops the version check when validating DMI data. No one fills this in on test systems and it causes too many failures that are unnecessary. The other checks are more important than this one.

To post a comment you must log in.
Revision history for this message
Rod Smith (rodsmith) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/miscellanea/jobs.pxu b/units/miscellanea/jobs.pxu
2index 59e41c2..30c8a16 100644
3--- a/units/miscellanea/jobs.pxu
4+++ b/units/miscellanea/jobs.pxu
5@@ -196,7 +196,7 @@ requires:
6 dmi_present.state == 'supported'
7 estimated_duration: 0.5
8 user: root
9-command: dmitest --test_versions server
10+command: dmitest server
11 _description:
12 Sanity check of DMI system identification data (for servers)
13 _summary:

Subscribers

People subscribed via source and target branches