Checkbox Provider - Base

Merge ~bladernr/plainbox-provider-checkbox:1729866-dont-run-lxc-as-root into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bladernr/plainbox-provider-checkbox
  3. 1729866-dont-run-lxc-as-root
  4. Merge into master
Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: 7c2c3e702f8860271d5d45a29f2490083063772b
Merged at revision: 5d3a92c709daa58308c53a571ebf4c24ee5e7212
Proposed branch: ~bladernr/plainbox-provider-checkbox:1729866-dont-run-lxc-as-root
Merge into: plainbox-provider-checkbox:master
Diff against target: 12 lines (+0/-1)
1 file modified
units/virtualization/jobs.pxu (+0/-1)
Reviewer Review Type Date Requested Status
Checkbox Developers Pending
Review via email: mp+333710@code.launchpad.net

Description of the change

Changes verifly_lxd test so that it doesn't run as root. This was causing a condition where attempting a restart of checkbox could crash because .config was being created by "lxc init auto" with root as the owner.

The test doesn't need root permissions to successfully run, so no harm in removing the elevation.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

self approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/virtualization/jobs.pxu b/units/virtualization/jobs.pxu
2index 39f37e9..faccf65 100644
3--- a/units/virtualization/jobs.pxu
4+++ b/units/virtualization/jobs.pxu
5@@ -18,7 +18,6 @@ _summary:
6 plugin: shell
7 category_id: com.canonical.plainbox::virtualization
8 id: virtualization/verify_lxd
9-user: root
10 environ: LXD_TEMPLATE LXD_ROOTFS
11 estimated_duration: 30.0
12 requires:

Subscribers

People subscribed via source and target branches