Merge ~bladernr/plainbox-provider-checkbox:1686746-network-info-show-speed into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Sylvain Pineau
Approved revision: c71173a9f525146301c8f3bc84df55652df0dc41
Merged at revision: fe98bbdd934426fd665557ea553952faa90ca20a
Proposed branch: ~bladernr/plainbox-provider-checkbox:1686746-network-info-show-speed
Merge into: plainbox-provider-checkbox:master
Diff against target: 36 lines (+13/-1)
1 file modified
bin/network_info (+13/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email: mp+323331@code.launchpad.net

Description of the change

Adds the contents of /sys/net/DEV/speed to the output of network_info script.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Useful indeed, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/network_info b/bin/network_info
2index 9c20b89..38d5ada 100755
3--- a/bin/network_info
4+++ b/bin/network_info
5@@ -51,12 +51,23 @@ def get_mac_address(interface):
6
7 address = ''
8 try:
9- address = _read_file(address_file)
10+ address = _read_file(address_file).strip()
11 except IOError:
12 pass
13
14 return address
15
16+def get_speed(interface):
17+ speed_file = os.path.join(SYS_PATH, interface, 'speed')
18+
19+ speed = ''
20+ try:
21+ speed = _read_file(speed_file).strip()
22+ except IOError:
23+ pass
24+
25+ return speed
26+
27
28 def main(args):
29 for interface in args:
30@@ -74,6 +85,7 @@ def main(args):
31 except:
32 print("IPv6: n/a")
33 print("MAC: %s\n" % get_mac_address(interface))
34+ print("Connect Speed: %s" % get_speed(interface))
35
36 return 0
37

Subscribers

People subscribed via source and target branches