Merge ~bladernr/plainbox-provider-checkbox:1672726-improve-get-make-model into plainbox-provider-checkbox:master
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Approved by: | Jeff Lane |
Approved revision: | 15a136e32ae8efea3a6883babfdd87ad36ba0955 |
Merged at revision: | 190c7ebd7eb3cf4d46311e42fa58dd8419aebe31 |
Proposed branch: | ~bladernr/plainbox-provider-checkbox:1672726-improve-get-make-model |
Merge into: | plainbox-provider-checkbox:master |
Diff against target: |
63 lines (+27/-19) 1 file modified
bin/get_make_and_model (+27/-19) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pierre Equoy | Approve | ||
Review via email: mp+319847@code.launchpad.net |
Description of the change
bin/get_
To post a comment you must log in.
I've tested this on my laptop.
Without the patch applied:
Manufacturer: Dell Inc.
Version: 01
Model: Latitude E5550 (Latitude E5550)
With the patch applied:
Mainboard:
Manufacturer: Dell Inc.
Version: A00
Model: 013BI2
System:
Manufacturer: Dell Inc.
Version: 01
Model: Latitude E5550 (Latitude E5550)
Looks good to me, but I'm wondering if the output of this script is not used in other parts that might be impacted by this change. I was for instance thinking of the C3 website, but when I check the page of the aforementioned laptop (https:/ /certification. canonical. com/hardware/ 201409- 15490/), it seems that the make/model data is not exactly the same anyway, so it probably gets this data from somewhere else.
I had a quick look and it seems this script has been introduced by Rod Smith and it's not called anywhere else other than in the miscellanea/ get_make_ and_model job, so it should be fine!
Added an inline comment too.