Merge ~bladernr/plainbox-provider-checkbox:1667781 into plainbox-provider-checkbox:master

[Jeff Lane ]

bin/network: dont exit if the target is not in the same subnet as the SUT, just warn and try it anyway. (Fixes bug when run in networks where the target IS in a different subnet with routes to reach the target).

[Pierre Equoy (pieq)]

Looks good to me.

review: Approve

diff --git a/bin/network b/bin/network
index 88fd931..4ebb786 100755
--- a/bin/network
+++ b/bin/network
@@ -448,10 +448,9 @@ def make_target_list(iface, test_targets, log_warnings):
             target = ipaddress.IPv4Address(test_target_ip)
             if (target < first_addr) or (target > last_addr):
                 if log_warnings:
-                    logging.warning("test server {} ({}) is NOT ".
-                                    format(test_target, target))
-                    logging.warning("within {}; skipping".format(net))
-                return_list.remove(test_target)
+                    logging.warning("Test server {} ({}) is NOT within {}".
+                                    format(test_target, target, net))
+                    logging.warning("This may cause test issues")
         except ValueError:
             if log_warnings:
                 logging.warning("Invalid address: {}; skipping".