Merge ~bladernr/plainbox-provider-checkbox:1655155 into plainbox-provider-checkbox:master
Proposed by
Jeff Lane
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sylvain Pineau | ||||
Approved revision: | 353587cf1d12e20250e58b33b2b5f2e8aabaef56 | ||||
Merged at revision: | 62b3636c2b7848ae9558c81ad2179a4b118e708d | ||||
Proposed branch: | ~bladernr/plainbox-provider-checkbox:1655155 | ||||
Merge into: | plainbox-provider-checkbox:master | ||||
Diff against target: |
75 lines (+32/-7) 1 file modified
bin/dmitest (+32/-7) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau | Approve | ||
Review via email: mp+314487@code.launchpad.net |
Description of the change
Fixes a problem where non-Unicode characters cause a traceback when attempting to decode (this triggers a traceback outside the try/except that check_output is in.
Now, the script attempts to get the output in one try/except, and then does the decoding elsewhere to catch that separately.
Also, it now tells you exactly which line in dmidecode output is responsible, and dumps the bytes representation of that line to output.
I also added a --show_dmi option for debugging things like this, so if you see bad things, you can re-run with --show_dmi and look for the places where the bad data lived.
To post a comment you must log in.
Nice improvement, +1