Merge ~bladernr/plainbox-provider-certification-server:1914457-usb-preinserted-broken-testplans into plainbox-provider-certification-server:master

Proposed by Jeff Lane 
Status: Rejected
Rejected by: Sylvain Pineau
Proposed branch: ~bladernr/plainbox-provider-certification-server:1914457-usb-preinserted-broken-testplans
Merge into: plainbox-provider-certification-server:master
Diff against target: 150 lines (+8/-21)
7 files modified
units/server-full-18.04.pxu (+2/-3)
units/server-full-20.04.pxu (+1/-3)
units/server-functional-18.04.pxu (+1/-3)
units/server-functional-20.04.pxu (+1/-3)
units/server-soc-cert-18.04.pxu (+1/-3)
units/server-soc-cert-20.04.pxu (+1/-3)
units/usb-only.pxu (+1/-3)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+397454@code.launchpad.net

Commit message

Remove individual old USB test items from testplan
Add new server-usb nested testplan to server suite testplans

Description of the change

Remove individual old USB test items from testplan
Add new server-usb nested testplan to server suite testplans

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [09:46:45] starting container
[xenial] [09:46:46] starting container
[focal] [09:46:47] starting container
Device project added to bionic-testing
Device project added to xenial-testing
Device project added to focal-testing
[xenial] [09:46:57] provisioning container
[focal] [09:47:05] provisioning container
[bionic] [09:47:06] provisioning container
[xenial] [09:47:30] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-certification-server
[bionic] [09:47:43] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-certification-server
[focal] [09:47:45] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-certification-server
[xenial] [09:48:28] container-tests-provider-certification-server: FAIL
[xenial] output: https://paste.ubuntu.com/p/mtrnCHZBdh/
[xenial] [09:48:30] Fixing file permissions in source directory
[xenial] [09:48:30] Destroying container
[focal] [09:48:40] container-tests-provider-certification-server: FAIL
[bionic] [09:48:41] container-tests-provider-certification-server: FAIL
[focal] output: https://paste.ubuntu.com/p/4J7sg6HyW5/
[focal] [09:48:42] Fixing file permissions in source directory
[focal] [09:48:43] Destroying container
[bionic] output: https://paste.ubuntu.com/p/HzbvPFRSfy/
[bionic] [09:48:43] Fixing file permissions in source directory
[bionic] [09:48:43] Destroying container

review: Needs Fixing

Unmerged commits

c3a8517... by Jeff Lane 

modify testplans to use new nested server-usb testplan lp: #1914457

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/server-full-18.04.pxu b/units/server-full-18.04.pxu
2index f74d4e8..7c58c4a 100644
3--- a/units/server-full-18.04.pxu
4+++ b/units/server-full-18.04.pxu
5@@ -13,6 +13,8 @@ nested_part:
6 com.canonical.certification::server-miscellaneous
7 com.canonical.certification::server-ethernet
8 com.canonical.certification::nvdimm-full
9+ com.canonical.certification::server-usb
10+
11 include:
12 info/hdparm_.*.txt certification-status=non-blocker
13 benchmarks/disk/hdparm-read_.* certification-status=blocker
14@@ -32,9 +34,6 @@ include:
15 optical/read-automated_.* certification-status=non-blocker
16 power-management/rtc certification-status=blocker
17 stress/cpu_stress_ng_test certification-status=blocker
18- usb/detect certification-status=non-blocker
19- usb/storage-preinserted certification-status=blocker
20- usb3/storage-preinserted certification-status=blocker
21 virtualization/verify_lxd certification-status=blocker
22 virtualization/kvm_check_vm certification-status=blocker
23 info/kvm_output certification-status=non-blocker
24diff --git a/units/server-full-20.04.pxu b/units/server-full-20.04.pxu
25index 16e4aa7..4ba3f67 100644
26--- a/units/server-full-20.04.pxu
27+++ b/units/server-full-20.04.pxu
28@@ -13,6 +13,7 @@ nested_part:
29 com.canonical.certification::server-miscellaneous
30 com.canonical.certification::server-ethernet
31 com.canonical.certification::nvdimm-full
32+ com.canonical.certification::server-usb
33 include:
34 info/hdparm_.*.txt certification-status=non-blocker
35 benchmarks/disk/hdparm-read_.* certification-status=blocker
36@@ -32,9 +33,6 @@ include:
37 optical/read-automated_.* certification-status=non-blocker
38 power-management/rtc certification-status=blocker
39 stress/cpu_stress_ng_test certification-status=blocker
40- usb/detect certification-status=non-blocker
41- usb/storage-preinserted certification-status=blocker
42- usb3/storage-preinserted certification-status=blocker
43 virtualization/verify_lxd certification-status=blocker
44 virtualization/kvm_check_vm certification-status=blocker
45 info/kvm_output certification-status=non-blocker
46diff --git a/units/server-functional-18.04.pxu b/units/server-functional-18.04.pxu
47index 1a64bd8..3be0613 100644
48--- a/units/server-functional-18.04.pxu
49+++ b/units/server-functional-18.04.pxu
50@@ -13,6 +13,7 @@ nested_part:
51 com.canonical.certification::server-miscellaneous
52 com.canonical.certification::server-ethernet
53 com.canonical.certification::nvdimm-full
54+ com.canonical.certification::server-usb
55 include:
56 info/hdparm_.*.txt certification-status=non-blocker
57 benchmarks/disk/hdparm-read_.* certification-status=blocker
58@@ -30,9 +31,6 @@ include:
59 optical/detect certification-status=non-blocker
60 optical/read-automated_.* certification-status=non-blocker
61 power-management/rtc certification-status=blocker
62- usb/detect certification-status=non-blocker
63- usb/storage-preinserted certification-status=blocker
64- usb3/storage-preinserted certification-status=blocker
65 virtualization/verify_lxd certification-status=blocker
66 virtualization/kvm_check_vm certification-status=blocker
67 info/kvm_output certification-status=non-blocker
68diff --git a/units/server-functional-20.04.pxu b/units/server-functional-20.04.pxu
69index 6492ca1..744c8dd 100644
70--- a/units/server-functional-20.04.pxu
71+++ b/units/server-functional-20.04.pxu
72@@ -13,6 +13,7 @@ nested_part:
73 com.canonical.certification::server-miscellaneous
74 com.canonical.certification::server-ethernet
75 com.canonical.certification::nvdimm-full
76+ com.canonical.certification::server-usb
77 include:
78 info/hdparm_.*.txt certification-status=non-blocker
79 benchmarks/disk/hdparm-read_.* certification-status=blocker
80@@ -30,9 +31,6 @@ include:
81 optical/detect certification-status=non-blocker
82 optical/read-automated_.* certification-status=non-blocker
83 power-management/rtc certification-status=blocker
84- usb/detect certification-status=non-blocker
85- usb/storage-preinserted certification-status=blocker
86- usb3/storage-preinserted certification-status=blocker
87 virtualization/verify_lxd certification-status=blocker
88 virtualization/kvm_check_vm certification-status=blocker
89 info/kvm_output certification-status=non-blocker
90diff --git a/units/server-soc-cert-18.04.pxu b/units/server-soc-cert-18.04.pxu
91index 7b57733..1a21563 100644
92--- a/units/server-soc-cert-18.04.pxu
93+++ b/units/server-soc-cert-18.04.pxu
94@@ -11,6 +11,7 @@ nested_part:
95 com.canonical.certification::server-firmware
96 com.canonical.certification::server-miscellaneous
97 com.canonical.certification::server-ethernet
98+ com.canonical.certification::server-usb
99 include:
100 info/hdparm_.*.txt certification-status=non-blocker
101 benchmarks/disk/hdparm-read_.*
102@@ -28,9 +29,6 @@ include:
103 memory/memory_stress_ng certification-status=blocker
104 power-management/rtc certification-status=blocker
105 stress/cpu_stress_ng_test certification-status=blocker
106- usb/detect certification-status=non-blocker
107- usb/storage-preinserted certification-status=blocker
108- usb3/storage-preinserted certification-status=blocker
109 virtualization/verify_lxd certification-status=blocker
110 virtualization/kvm_check_vm certification-status=blocker
111 info/kvm_output certification-status=non-blocker
112diff --git a/units/server-soc-cert-20.04.pxu b/units/server-soc-cert-20.04.pxu
113index 241cdd1..c913564 100644
114--- a/units/server-soc-cert-20.04.pxu
115+++ b/units/server-soc-cert-20.04.pxu
116@@ -11,6 +11,7 @@ nested_part:
117 com.canonical.certification::server-firmware
118 com.canonical.certification::server-miscellaneous
119 com.canonical.certification::server-ethernet
120+ com.canonical.certification::server-usb
121 include:
122 info/hdparm_.*.txt certification-status=non-blocker
123 benchmarks/disk/hdparm-read_.*
124@@ -28,9 +29,6 @@ include:
125 memory/memory_stress_ng certification-status=blocker
126 power-management/rtc certification-status=blocker
127 stress/cpu_stress_ng_test certification-status=blocker
128- usb/detect certification-status=non-blocker
129- usb/storage-preinserted certification-status=blocker
130- usb3/storage-preinserted certification-status=blocker
131 virtualization/verify_lxd certification-status=blocker
132 virtualization/kvm_check_vm certification-status=blocker
133 info/kvm_output certification-status=non-blocker
134diff --git a/units/usb-only.pxu b/units/usb-only.pxu
135index 9c61016..81500c6 100644
136--- a/units/usb-only.pxu
137+++ b/units/usb-only.pxu
138@@ -10,11 +10,9 @@ nested_part:
139 com.canonical.certification::server-info-attachment-automated
140 com.canonical.certification::server-firmware
141 com.canonical.certification::server-miscellaneous
142+ com.canonical.certification::server-usb
143 include:
144 info/hdparm_.*.txt
145- usb/detect
146- usb/storage-preinserted certification-status=blocker
147- usb3/storage-preinserted certification-status=blocker
148 miscellanea/oops certification-status=non-blocker
149 miscellanea/oops_results.log certification-status=non-blocker
150 miscellanea/olog certification-status=blocker

Subscribers

People subscribed via source and target branches