Merge ~bladernr/plainbox-provider-certification-server:1742455-packaging-for-testplan-launchers into ~checkbox-dev/plainbox-provider-certification-server/+git/packaging:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: ec601de43c69575f8979600e15bcaf178ff4bf0b
Merged at revision: 6f77de27766982f0a89ae3fb685d5668681a8408
Proposed branch: ~bladernr/plainbox-provider-certification-server:1742455-packaging-for-testplan-launchers
Merge into: ~checkbox-dev/plainbox-provider-certification-server/+git/packaging:master
Diff against target: 105 lines (+67/-3)
3 files modified
debian/canonical-certification-server.install (+14/-0)
debian/canonical-certification-server.lintian-overrides (+15/-0)
debian/canonical-certification-server.rst (+38/-3)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+336010@code.launchpad.net

Description of the change

Modified packaging to install newly created launcher files.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Some minor questions, but not necessarily anything that needs to be fixed. See what you think, but +1 otherwise.

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

Thanks for pointing that one line out. It was, indeed, not meant to be inconsistent with the rest, so I changed it.

As for the wrapper script, it's more a personal preference. Consider it basically a "launcher" for checkbox-cli to submit results. I'd prefer to provide the users (who are 95% outside Canonical and are our "customers" as well as "partners") a specific command that looks more "Official".

I realize it's 6 of one, 1/2 dozen of the other here, so it really is just a personal preference to have them use "canonical-certification-submit" as the official "tool" to submit. We've been using CCS for years at this point, and there isn't a really compelling reason to fall back to "call the underlying back-end directly".

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/canonical-certification-server.install b/debian/canonical-certification-server.install
2index 6bc3341..93c7c7e 100644
3--- a/debian/canonical-certification-server.install
4+++ b/debian/canonical-certification-server.install
5@@ -1 +1,15 @@
6 usr/bin/canonical-certification-server
7+usr/bin/certify-16.04
8+usr/bin/certify-soc-16.04
9+usr/bin/certify-vm-16.04
10+usr/bin/test-functional-14.04
11+usr/bin/test-network-14.04
12+usr/bin/test-storage
13+usr/bin/test-virtualziation
14+usr/bin/certify-14.04
15+usr/bin/certify-soc-14.04
16+usr/bin/certify-vm-14.04
17+usr/bin/test-firmware
18+usr/bin/test-functional-16.04
19+usr/bin/test-network-16.04
20+usr/bin/test-usb
21diff --git a/debian/canonical-certification-server.lintian-overrides b/debian/canonical-certification-server.lintian-overrides
22index 89960b8..e8cc403 100644
23--- a/debian/canonical-certification-server.lintian-overrides
24+++ b/debian/canonical-certification-server.lintian-overrides
25@@ -2,3 +2,18 @@
26 canonical-certification-server: new-package-should-close-itp-bug
27 # Those are the desired (custom) interpreters
28 canonical-certification-server: unusual-interpreter usr/bin/canonical-certification-server #!checkbox-launcher
29+canonical-certification-server: unusual-interpreter usr/bin/canonical-certification-server #!checkbox-cli
30+canonical-certification-server: unusual-interpreter usr/bin/certify-14.04 #!checkbox-cli
31+canonical-certification-server: unusual-interpreter usr/bin/certify-16.04 #!checkbox-cli
32+canonical-certification-server: unusual-interpreter usr/bin/certify-soc-14.04 #!checkbox-cli
33+canonical-certification-server: unusual-interpreter usr/bin/certify-soc-16.04 #!checkbox-cli
34+canonical-certification-server: unusual-interpreter usr/bin/certify-vm-14.04 #!checkbox-cli
35+canonical-certification-server: unusual-interpreter usr/bin/certify-vm-16.04 #!checkbox-cli
36+canonical-certification-server: unusual-interpreter usr/bin/test-firmware #!checkbox-cli
37+canonical-certification-server: unusual-interpreter usr/bin/test-functional-14.04 #!checkbox-cli
38+canonical-certification-server: unusual-interpreter usr/bin/test-functional-16.04 #!checkbox-cli
39+canonical-certification-server: unusual-interpreter usr/bin/test-network-14.04 #!checkbox-cli
40+canonical-certification-server: unusual-interpreter usr/bin/test-network-16.04 #!checkbox-cli
41+canonical-certification-server: unusual-interpreter usr/bin/test-storage #!checkbox-cli
42+canonical-certification-server: unusual-interpreter usr/bin/test-usb #!checkbox-cli
43+canonical-certification-server: unusual-interpreter usr/bin/test-virtualziation #!checkbox-cli
44diff --git a/debian/canonical-certification-server.rst b/debian/canonical-certification-server.rst
45index 95ba797..a2cf884 100644
46--- a/debian/canonical-certification-server.rst
47+++ b/debian/canonical-certification-server.rst
48@@ -7,11 +7,39 @@ performs interactive system testing in console mode and sends results to Canonic
49 --------------------------------------------------------------------------------------------------------
50
51 :Manual section: 1
52-:Author: Sylvain Pineau, 2015
53+:Author: Jeffrey Lane, 2018
54
55 SYNOPSIS
56 ========
57- canonical-certification-server
58+ For certifying bare metal servers, and most certification test scenaros:
59+ certify-16.04
60+ certify-14.04
61+
62+ For certifying Systems on Chip:
63+ certify-soc-16.04
64+ certify-soc-14.04
65+
66+ For certifying Ubuntu as a Guest on a Hypervisor:
67+ certify-vm-16.04
68+ certify-vm-14.04
69+
70+ Abbreviated functional test that does not include lengthy stress tests:
71+ test-functional-14.04
72+
73+ Retest commands for running retests on a specific subsystem:
74+ test-network-16.04
75+ test-network-14.04
76+ test-storage
77+ test-virtualziation
78+ test-firmware
79+ test-usb
80+
81+ Runs functional testing only, no stress test cases are executed:
82+ test-functional-16.04
83+ test-functional-14.04
84+
85+ Runs checkbox-cli with full list of test plans and cases to select:
86+ canonical-certification-server
87
88 OPTIONS
89 =======
90@@ -31,7 +59,14 @@ manual tests to confirm that the system is working properly. Finally, you will
91 be asked for the Secure ID of the computer to submit the information to the
92 certification.canonical.com database.
93
94+Testers shoud run any of the certify-* commands to submit official
95+certification tests to Canonical. Should retests be necessary, the tester will
96+be directed to run one of the retest commands by the Certification Team.
97+
98 TEST PLAN SELECTION
99 ===================
100
101-This program will allow you to select test any test plan.
102+The command 'canonical-certification-server' will allow you to select test any
103+test plan. The other commands will launch certification without the ability to
104+alter selections and these are the commands that should be used for
105+certification testing unless otherwise instructed.

Subscribers

People subscribed via source and target branches