Provider for Plainbox - Canonical Certification Server

Merge ~bladernr/plainbox-provider-certification-server:remove-old-storage-test into plainbox-provider-certification-server:master

  1. Git
  2. lp:~bladernr/plainbox-provider-certification-server
  3. remove-old-storage-test
  4. Merge into master
Proposed by Jeff Lane 
Status: Merged
Approved by: Po-Hsu Lin
Approved revision: 6bede23639bee69462f4a7e348bd22a0c50ccea7
Merged at revision: a6fa29e46952a3534ef6fd17b93feb8941a6208d
Proposed branch: ~bladernr/plainbox-provider-certification-server:remove-old-storage-test
Merge into: plainbox-provider-certification-server:master
Diff against target: 74 lines (+8/-6)
5 files modified
launcher/canonical-certification-server (+7/-2)
units/server-full-16.04.pxu (+0/-1)
units/server-functional-16.04.pxu (+0/-1)
units/server-soc-cert-16.04.pxu (+1/-1)
units/virtual-machine-full-16.04.pxu (+0/-1)
Reviewer Review Type Date Requested Status
Pierre Equoy Approve
Review via email: mp+307874@code.launchpad.net

Description of the change

Removes references to the older storage_devices test (based on Bonnie) from the 16.04 whitelists.

To post a comment you must log in.
Revision history for this message
Pierre Equoy (pieq) wrote :

+1

Pretty creative way of using Checkbox launchers, I have to say... :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launcher/canonical-certification-server b/launcher/canonical-certification-server
2index fcf8324..029ca14 100755
3--- a/launcher/canonical-certification-server
4+++ b/launcher/canonical-certification-server
5@@ -1,12 +1,17 @@
6-#!/usr/bin/env checkbox-cli
7+#!/bin/bash
8+
9+RELEASE=`lsb_release -r |cut -f 2`
10+
11+cat << EOF | /usr/bin/env checkbox-cli
12 [launcher]
13 app_id = 2013.com.canonical.certification:certification-server
14 launcher_version = 1
15 stock_reports = text, submission_files, certification
16
17 [test plan]
18-unit = 2013.com.canonical.certification::16.04-server-full
19+unit = 2013.com.canonical.certification::$RELEASE-server-full
20 filter = *-server-*, *-only, *virtual*, *firmware-tests
21
22 [config]
23 config_filename = canonical-certification.conf
24+EOF
25diff --git a/units/server-full-16.04.pxu b/units/server-full-16.04.pxu
26index 0c0d1a3..0222f57 100644
27--- a/units/server-full-16.04.pxu
28+++ b/units/server-full-16.04.pxu
29@@ -55,7 +55,6 @@ include:
30 disk/stats_.* certification-status=blocker
31 disk/read_performance_.* certification-status=blocker
32 disk/smart_.* certification-status=non-blocker
33- disk/storage_device_.* certification-status=blocker
34 disk/disk_stress_ng_.* certification-status=blocker
35 disk/disk_cpu_load_.* certification-status=non-blocker
36 ethernet/detect certification-status=non-blocker
37diff --git a/units/server-functional-16.04.pxu b/units/server-functional-16.04.pxu
38index 0e812c6..c3e2523 100644
39--- a/units/server-functional-16.04.pxu
40+++ b/units/server-functional-16.04.pxu
41@@ -55,7 +55,6 @@ include:
42 disk/stats_.* certification-status=blocker
43 disk/read_performance_.* certification-status=blocker
44 disk/smart_.* certification-status=non-blocker
45- disk/storage_device_.* certification-status=blocker
46 disk/disk_stress_ng_.* certification-status=blocker
47 disk/disk_cpu_load_.* certification-status=non-blocker
48 ethernet/detect certification-status=non-blocker
49diff --git a/units/server-soc-cert-16.04.pxu b/units/server-soc-cert-16.04.pxu
50index c96e7a0..ecd4b89 100644
51--- a/units/server-soc-cert-16.04.pxu
52+++ b/units/server-soc-cert-16.04.pxu
53@@ -49,8 +49,8 @@ include:
54 disk/stats_.* certification-status=blocker
55 disk/read_performance_.* certification-status=blocker
56 disk/smart_.* certification-status=non-blocker
57- disk/storage_device_.* certification-status=blocker
58 disk/disk_stress_ng_.* certification-status=blocker
59+ disk/disk_cpu_load_.* certification-status=non-blocker
60 ethernet/detect certification-status=non-blocker
61 ethernet/info_automated certification-status=non-blocker
62 ethernet/ethtool_info certification-status=non-blocker
63diff --git a/units/virtual-machine-full-16.04.pxu b/units/virtual-machine-full-16.04.pxu
64index e1c23de..ca5d551 100644
65--- a/units/virtual-machine-full-16.04.pxu
66+++ b/units/virtual-machine-full-16.04.pxu
67@@ -49,7 +49,6 @@ include:
68 disk/stats_.* certification-status=blocker
69 disk/read_performance_.* certification-status=blocker
70 disk/smart_.* certification-status=non-blocker
71- disk/storage_device_.* certification-status=blocker
72 disk/disk_stress_ng_.* certification-status=blocker
73 disk/disk_cpu_load_.* certification-status=non-blocker
74 ethernet/detect certification-status=non-blocker

Subscribers

People subscribed via source and target branches