Merge ~bladernr/plainbox-provider-certification-server:1621986-modify-config into plainbox-provider-certification-server:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 7537d1b9fe591d1ba407d4a56d7a5e587e105da5
Merged at revision: 41e3bda65786b8899972b01b104dc0a65145a874
Proposed branch: ~bladernr/plainbox-provider-certification-server:1621986-modify-config
Merge into: plainbox-provider-certification-server:master
Diff against target: 35 lines (+19/-5)
1 file modified
configs/canonical-certification.conf (+19/-5)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Rod Smith Approve
Jeff Lane  Needs Resubmitting
Review via email: mp+305492@code.launchpad.net

Description of the change

Modify config file to reflect changes in the virtualization script per this MERGE:
https://code.launchpad.net/~bladernr/checkbox/1621986-virt-accept-urls

To post a comment you must log in.
Revision history for this message
Rod Smith (rodsmith) wrote :

A couple of typos and formatting suggestions, as well as one to alter an example.

review: Needs Fixing
Revision history for this message
Jeff Lane  (bladernr) wrote :

Thanks for the catch on those. I've updated accordingly.

review: Needs Resubmitting
Revision history for this message
Rod Smith (rodsmith) wrote :

Looks good!

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/configs/canonical-certification.conf b/configs/canonical-certification.conf
2index c6b2248..fccd579 100644
3--- a/configs/canonical-certification.conf
4+++ b/configs/canonical-certification.conf
5@@ -20,12 +20,26 @@ welcome_text = Welcome to System Certification!
6 #
7 # KVM_TIMEOUT sets the timeout to wait for the cloudimg to boot before exiting
8 # test. It is an integer in seconds (the default is 3000 seconds)
9-# KVM_IMAGE is the path to the local copy of the cloud image to use for
10-# testing. This is necessary if you are in a disconnected environment and have
11-# a copy of the cloudimg file on your SUT's local filesystem. This should be a
12-# full path.
13+# KVM_IMAGE the location to find the cloud image to use for testing KVM. This
14+# will allow you to specify a variety of location options depending on your
15+# needs.
16+# Options available:
17+# - http://myserver.com/imagedir/ (note the trailing / is required!!)
18+# - This will tell the script to look into /imagedir/ on the remote server
19+# for files in the standard ubuntu Cloud filename format
20+# RELEASE-server-cloudimg-ARCH-disk1.img
21+# - http://someotherserver.net/imagedir/ubuntu/mycloudimg.img
22+# - This will tell the script to download the file mycloudimg.img from the
23+# remote server.
24+# - file:///local/path/to/cloud.img
25+# - This will tell the script to look at the path specified on the local
26+# filesystem for a copy of the cloud image to use.
27+# - /local/path/to/cloud.img
28+# - This will work the same as the file:// example above and should be a
29+# full path to the cloud image.
30 #
31-# UNCOMMENT THE FOLLOWING 2 LINES and set the proper parameters as necessary:
32+# UNCOMMENT EITHER OR BOTH OF THE FOLLOWING 2 LINES and set the proper
33+# parameters as necessary:
34 #KVM_TIMEOUT = 300
35 #KVM_IMAGE = /path/to/cloudimage-filename.img
36

Subscribers

People subscribed via source and target branches