Merge ~bladernr/plainbox-provider-certification-server/+git/packaging:1968097-packaging-22.04-updates into ~checkbox-dev/plainbox-provider-certification-server/+git/packaging:master

[Jeff Lane ]

Update packaging for 22.04

Update packaging for 22.04. I'm not sure if this will actually work though, so if not, reject and I'll do it the long way.

[Jeff Lane  (bladernr)]

So interestingly, I had to explicitly tell it to install debian/tmp/usr/bin as well, but that seems to now work:

bladernr@galactica:~/development$ dpkg-deb --contents canonical-certification-server_0.56.0-1_all.deb
drwxr-xr-x root/root 0 2021-11-22 05:18 ./
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/bin/
-rwxr-xr-x root/root 379 2020-04-24 16:01 ./usr/bin/certify-18.04
-rwxr-xr-x root/root 379 2020-04-24 16:01 ./usr/bin/certify-20.04
-rwxr-xr-x root/root 379 2021-11-22 05:18 ./usr/bin/certify-22.04
-rwxr-xr-x root/root 383 2018-03-28 13:49 ./usr/bin/certify-soc-18.04
-rwxr-xr-x root/root 383 2020-04-20 16:10 ./usr/bin/certify-soc-20.04
-rwxr-xr-x root/root 383 2021-11-22 05:18 ./usr/bin/certify-soc-22.04
-rwxr-xr-x root/root 388 2018-03-28 13:49 ./usr/bin/certify-vm-18.04
-rwxr-xr-x root/root 388 2020-04-29 17:24 ./usr/bin/certify-vm-20.04
-rwxr-xr-x root/root 388 2021-11-22 05:18 ./usr/bin/certify-vm-22.04
-rwxr-xr-x root/root 370 2020-04-20 16:10 ./usr/bin/test-cpu
-rwxr-xr-x root/root 376 2018-03-28 13:49 ./usr/bin/test-firmware
-rwxr-xr-x root/root 385 2020-04-24 16:04 ./usr/bin/test-functional-18.04
-rwxr-xr-x root/root 385 2020-04-24 16:04 ./usr/bin/test-functional-20.04
-rwxr-xr-x root/root 385 2021-11-22 05:18 ./usr/bin/test-functional-22.04
-rwxr-xr-x root/root 373 2019-01-21 10:24 ./usr/bin/test-memory
-rwxr-xr-x root/root 343 2020-06-24 16:56 ./usr/bin/test-network
-rwxr-xr-x root/root 385 2020-04-24 16:04 ./usr/bin/test-network-underspeed
-rwxr-xr-x root/root 373 2020-07-31 09:53 ./usr/bin/test-nvdimm
-rwxr-xr-x root/root 595 2020-04-24 16:04 ./usr/bin/test-regression
-rwxr-xr-x root/root 343 2020-06-24 16:56 ./usr/bin/test-storage
-rwxr-xr-x root/root 373 2019-01-21 10:24 ./usr/bin/test-stress
-rwxr-xr-x root/root 370 2018-03-28 13:49 ./usr/bin/test-usb
-rwxr-xr-x root/root 381 2020-04-24 16:05 ./usr/bin/test-virtualization
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/share/
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/share/doc/canonical-certification-server/
-rw-r--r-- root/root 614 2021-11-22 05:18 ./usr/share/doc/canonical-certification-server/changelog.Debian.gz
-rw-r--r-- root/root 934 2016-07-18 18:26 ./usr/share/doc/canonical-certification-server/copyright
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/share/lintian/
drwxr-xr-x root/root 0 2021-11-22 05:18 ./usr/share/lintian/overrides/
-rw-r--r-- root/root 1698 2020-05-21 11:42 ./usr/share/lintian/overrides/canonical-certification-server

[Jeff Lane  (bladernr)]

I like that, no more packaging updates when we add/remove launchers.

[Rod Smith (rodsmith)]

LGTM; however, I know little enough about Checkbox packaging that you might want to wait for a second opinion before merging.

review: Approve

[Sylvain Pineau (sylvain-pineau)]

I'd just use this selection in canonical-certification-server.install:

/usr/bin

From http://manpages.ubuntu.com/manpages/focal/man1/dh_install.1.html:

           Note that if you list exactly one filename or wildcard-pattern on a line by itself,
           with no explicit destination, then dh_install will automatically guess the destination
           to use, the same as if the --autodest option were used.

[Jeff Lane  (bladernr)]

Huh... ok... I misread how dh_install worked when I was doing this earlier. Just changed it to simply /usr/bin, built and tested the package and it does do everything it should. Magic.

I'll approve this and the other one now and that should take care of CCS for a bit.

diff --git a/debian/canonical-certification-server.install b/debian/canonical-certification-server.install
index 1d14f38..bc7b689 100644
--- a/debian/canonical-certification-server.install
+++ b/debian/canonical-certification-server.install
@@ -1,19 +1 @@
-usr/bin/certify-18.04
-usr/bin/certify-20.04
-usr/bin/certify-soc-18.04
-usr/bin/certify-soc-20.04
-usr/bin/certify-vm-18.04
-usr/bin/certify-vm-20.04
-usr/bin/test-cpu
-usr/bin/test-firmware
-usr/bin/test-functional-18.04
-usr/bin/test-functional-20.04
-usr/bin/test-memory
-usr/bin/test-network
-usr/bin/test-network-underspeed
-usr/bin/test-nvdimm
-usr/bin/test-regression
-usr/bin/test-storage
-usr/bin/test-stress
-usr/bin/test-usb
-usr/bin/test-virtualization
+/usr/bin/