Merge lp:~bladernr/checkbox/fix-config-file-vars into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 9
Merged at revision: 9
Proposed branch: lp:~bladernr/checkbox/fix-config-file-vars
Merge into: lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Diff against target: 19 lines (+2/-2)
1 file modified
debian/extras/canonical-certification-config/canonical-certification.conf (+2/-2)
To merge this branch: bzr merge lp:~bladernr/checkbox/fix-config-file-vars
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+216396@code.launchpad.net

Description of the change

fixes a couple of hte default variable entries so they aren't accidentally left blank.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Blank values shouldn't cause the test to crash, if you have some time could you please file a bug about that? file it on the "plainbox-provider-checkbox" project (https://bugs.launchpad.net/plainbox-provider-checkbox/).

This is fine as a workaround and due to its simplicity I think it's OK to merge this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/extras/canonical-certification-config/canonical-certification.conf'
2--- debian/extras/canonical-certification-config/canonical-certification.conf 2014-04-01 16:05:51 +0000
3+++ debian/extras/canonical-certification-config/canonical-certification.conf 2014-04-17 21:28:44 +0000
4@@ -16,7 +16,7 @@
5 [environment]
6 # For virtualization testing.
7 # Uncomment the following 2 lines and set the proper parameters:
8-#KVM_TIMEOUT =
9+#KVM_TIMEOUT = 3000
10 #KVM_IMAGE =
11 # For network testing.
12 # WARNING: ALL four parameters need a value, don't leave anything
13@@ -24,5 +24,5 @@
14 # Uncomment the following 4 lines and set the proper parameters:
15 #TEST_TARGET_FTP = your-ftp-server.example.com
16 #TEST_USER = anonymous
17-#TEST_PASS =
18+#TEST_PASS = password
19 #TEST_TARGET_IPERF = your-iperf-server.example.com

Subscribers

People subscribed via source and target branches