Merge lp:~bladernr/checkbox/clarify-cd_dvd-write-tests into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1125
Proposed branch: lp:~bladernr/checkbox/clarify-cd_dvd-write-tests
Merge into: lp:checkbox
Diff against target: 21 lines (+2/-2)
1 file modified
jobs/optical.txt.in (+2/-2)
To merge this branch: bzr merge lp:~bladernr/checkbox/clarify-cd_dvd-write-tests
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Jeff Lane  Needs Resubmitting
Review via email: mp+82350@code.launchpad.net

Description of the change

Clarified the intent of the cd-write and dvd-write tests in optical.txt. Now they specifically say "If your drive doesnt support this, skip this test"

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Do we want to say 'or if you don't have any writable media available then please skip the test?'. It should be obvious, but might be worth stating explicitly.

review: Needs Information
Revision history for this message
Jeff Lane  (bladernr) wrote :

Sounds like a good idea. Strings tweaked accordingly.

review: Needs Resubmitting
1126. By Jeff Lane 

added further skip conditions to be absolutely clear

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Looks nice, approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/optical.txt.in'
2--- jobs/optical.txt.in 2011-10-07 18:59:33 +0000
3+++ jobs/optical.txt.in 2011-11-16 14:42:23 +0000
4@@ -35,7 +35,7 @@
5 requires: device.category == 'CDROM'
6 _description:
7 PURPOSE:
8- This test will check your CDROM writing capabilities
9+ This test will check your system's CDROM writing capabilities. If your drive does not support writing CDs or you do not have any blank CD media, please skip this test.
10 STEPS:
11 1. Enter a blank CDROM into your drive
12 2. Write something in the CDROM
13@@ -68,7 +68,7 @@
14 requires: device.category == 'CDROM'
15 _description:
16 PURPOSE:
17- This test will check your DVD writing capabilities
18+ This test will check your system's DVD writing capabilities. If your drive does not support writing DVDs or you do not have any blank DVD media, please skip this test.
19 STEPS:
20 1. Enter a blank DVD into your drive
21 2. Write something in the DVD

Subscribers

People subscribed via source and target branches