Merge lp:~bladernr/checkbox/954606-fix-optical-descriptions into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1323
Proposed branch: lp:~bladernr/checkbox/954606-fix-optical-descriptions
Merge into: lp:checkbox
Diff against target: 60 lines (+13/-10)
2 files modified
debian/changelog (+3/-1)
jobs/optical.txt.in (+10/-9)
To merge this branch: bzr merge lp:~bladernr/checkbox/954606-fix-optical-descriptions
Reviewer Review Type Date Requested Status
TienFu Chen (community) Approve
Checkbox Developers Pending
Review via email: mp+97506@code.launchpad.net

Description of the change

Fixed some job descriptions in optical.txt to account for changes in the UI for Precise.

To post a comment you must log in.
Revision history for this message
TienFu Chen (ctf) wrote :

Looks good, thanks.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

Merged based on Tim's approval. Fixed changelog :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-13 22:52:01 +0000
3+++ debian/changelog 2012-03-14 19:53:26 +0000
4@@ -11,6 +11,8 @@
5 [Jeff Lane]
6 * Reset default checkbox log level to INFO from DEBUG to make logs less
7 confusing and verbose. (LP: #949745)
8+ * Fixed the job descriptions for optical/read and optical/cdrom-audio-playback
9+ to account for changes in Precise and make them less confusing (LP: #954606)
10
11 [Marc Tardif]
12 * Linted qt_interface which had a few syntax errors (LP: #949957)
13@@ -20,7 +22,7 @@
14 * jobs/keys.txt.in: Fix definition for keys/media-keys test which failed to
15 run (LP: #954480)
16
17- -- Jeff Lane <jeff@ubuntu.com> Tue, 13 Mar 2012 18:51:20 -0400
18+ -- Jeff Lane <jeff@ubuntu.com> Wed, 14 Mar 2012 15:47:21 -0400
19
20 checkbox (0.13.4) precise; urgency=low
21
22
23=== modified file 'jobs/optical.txt.in'
24--- jobs/optical.txt.in 2012-02-15 16:20:14 +0000
25+++ jobs/optical.txt.in 2012-03-14 19:53:26 +0000
26@@ -18,10 +18,11 @@
27 This test will check your optical devices ability to read CD media
28 STEPS:
29 1. Insert appropriate non-blank media into your optical drive(s). Movie and Audio Disks may not work. Self-created data disks have the greatest chance of working.
30- 2. If a file browser does not open automatically, open the file browser and access the disk.
31- 3. Attempt to open a text file on the disk, or copy a file from the disk to your home directory.
32+ 2. If a file browser window opens, you can safely close or ignore that window.
33+ 3. Click "Test" to being the test.
34+ 4. When the test completes, proceed by clicking "Next"
35 VERIFICATION:
36- Were you able to view files on the disk and either open a file to read or copy a file to your home directory?
37+ This test should automatically select "Yes" if it passes, "No" if it fails.
38
39 plugin: manual
40 name: optical/cdrom-write
41@@ -49,14 +50,14 @@
42 This test will check your CD audio playback capabilities
43 STEPS:
44 1. Insert an audio CD in your optical drive
45- 2. Open the Dash (click on the Ubuntu Circle of Friends button on the Launcher)
46- 3. Click "Listen to Music" to open Banshee
47- 4. Select the CD under "Libraries" in the left panel of Banshee
48- 5. Click the Play button to listen to music
49+ 2. When prompted, launch the Music Player
50+ 3. Locate the CD in the display of the Music Player
51+ 4. Select the CD in the Music Player
52+ 5. Click the Play button to listen to the music on the CD
53 6. Stop playing after some time
54- 7. Right click on the CD icon under "Libraries" and select "Eject Disc"
55+ 7. Right click on the CD icon and select "Eject Disc"
56 8. The CD should be ejected
57- 9. Close Banshee
58+ 9. Close the Music Player
59 VERIFICATION:
60 Did all the steps work?
61

Subscribers

People subscribed via source and target branches