Merge lp:~bladernr/checkbox/1585802-udev_resource-virtual-disks into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4381
Merged at revision: 4380
Proposed branch: lp:~bladernr/checkbox/1585802-udev_resource-virtual-disks
Merge into: lp:checkbox
Diff against target: 17 lines (+7/-0)
1 file modified
checkbox-support/checkbox_support/parsers/udevadm.py (+7/-0)
To merge this branch: bzr merge lp:~bladernr/checkbox/1585802-udev_resource-virtual-disks
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+295845@code.launchpad.net

Description of the change

Add a bit to have udevadm parser ignore devices where product is "Virtual Floppy" or "Virtual SDD/HDD" as those are fake devices created by Cisco CIMC to pass files from remote management connections.

To post a comment you must log in.
4380. By Jeff Lane 

Whoops, forgot the parenthesis

4381. By Jeff Lane 

Added a string I missed for Virtual CDROM

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thanks, I hope you covered all of them ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-support/checkbox_support/parsers/udevadm.py'
2--- checkbox-support/checkbox_support/parsers/udevadm.py 2016-05-18 07:21:31 +0000
3+++ checkbox-support/checkbox_support/parsers/udevadm.py 2016-05-26 17:23:23 +0000
4@@ -857,6 +857,13 @@
5 if device.vendor == "iDRAC":
6 return True
7
8+ # Ignore virtual devices created by Cisco CIMC manager
9+ # See pad.lv/1585802
10+ if (device.product == "Virtual FDD/HDD" or
11+ device.product == "Virtual Floppy" or
12+ device.product == "Virtual CD/DVD"):
13+ return True
14+
15 return False
16
17 def getAttributes(self, path):

Subscribers

People subscribed via source and target branches