Merge lp:~bladernr/checkbox/1519383-add-tower-ff-dmitest into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Po-Hsu Lin
Approved revision: 4112
Merged at revision: 4113
Proposed branch: lp:~bladernr/checkbox/1519383-add-tower-ff-dmitest
Merge into: lp:checkbox
Diff against target: 13 lines (+2/-1)
1 file modified
providers/plainbox-provider-checkbox/bin/dmitest (+2/-1)
To merge this branch: bzr merge lp:~bladernr/checkbox/1519383-add-tower-ff-dmitest
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Review via email: mp+278464@code.launchpad.net

Description of the change

Adds tower to dmitest as a valid server form factor.

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Looks good to me, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/bin/dmitest'
2--- providers/plainbox-provider-checkbox/bin/dmitest 2015-09-01 16:30:32 +0000
3+++ providers/plainbox-provider-checkbox/bin/dmitest 2015-11-24 15:27:19 +0000
4@@ -113,7 +113,8 @@
5 if args.test_type == 'server':
6 if not find_in_section(stream, 'Chassis Information', 'Type:',
7 ['server', 'rack mount', 'blade',
8- 'expansion chassis', 'multi-system'], False):
9+ 'expansion chassis', 'multi-system', 'tower'],
10+ False):
11 print("*** Incorrect or unknown server chassis type!")
12 retval += 1
13 if find_in_section(stream, 'Base Board Information', 'Type:',

Subscribers

People subscribed via source and target branches