Merge lp:~bladernr/checkbox/1341769-fix-info_disk_partitions into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 3120
Merged at revision: 3120
Proposed branch: lp:~bladernr/checkbox/1341769-fix-info_disk_partitions
Merge into: lp:checkbox
Diff against target: 10 lines (+1/-1)
1 file modified
providers/plainbox-provider-checkbox/jobs/info.txt.in (+1/-1)
To merge this branch: bzr merge lp:~bladernr/checkbox/1341769-fix-info_disk_partitions
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+226747@code.launchpad.net

Description of the change

prevent 'parted -l' from hanging waiting for user input when something happens (like GPT table issues).

This is an info attachment job so shouldn't hold up the entire suite, nor will it generate any FAIL message in the results, but any errors that parted spits out should be captured in the output that is attached to the submission should investigation be necessary.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, short and sweet. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/jobs/info.txt.in'
2--- providers/plainbox-provider-checkbox/jobs/info.txt.in 2014-06-09 20:04:21 +0000
3+++ providers/plainbox-provider-checkbox/jobs/info.txt.in 2014-07-14 21:02:52 +0000
4@@ -229,6 +229,6 @@
5 plugin: attachment
6 id: info/disk_partitions
7 user: root
8-command: parted -l
9+command: parted -l -s
10 _description: Attaches information about disk partitions
11

Subscribers

People subscribed via source and target branches