Merge lp:~bladernr/checkbox/1330998-tickless-idle-not-on-arm into lp:checkbox

[Jeff Lane ]

changes power-management/tickless_idle to not run on arm/arm64 systems.

[Daniel Manrique (roadmr)]

Hi Jeff,

I think negative resources (like what you're using, "ELEMENT not in SET") don't work properly in plainbox (nor do they in checkbox, for that matter).

Maybe you'd be OK with changing that to:

requires: cpuinfo.type in ('i386', 'amd64')

I think this makes sense as (can we ask Ashley about this?) I don't think power-based archs will have tickless idle either.

review: Needs Information

[Zygmunt Krynicki (zyga)]

Curiously enough both will (should) work. If you get any issues I'll try to fix it quickly. The common problem with not in and != is that we have implicit any() around the whole expression and that leads to spurious 'successes' in other iterations of the loop. See: http://plainbox.readthedocs.org/en/latest/dev/resources.html#operator-is-useless

[Jeff Lane  (bladernr)]

ubuntu@am3:~$ /usr/lib/2013.com.canonical.certification\:plainbox-resources/bin/cpuinfo_resource
count: 8
model: aarch64
platform: aarch64
speed: -2
type: aarch64

ubuntu@am3:~$ grep -a4 -b2 tickless_idle /usr/share/2013.com.canonical.certification\:checkbox/jobs/power-management.txt.in
4482-
4483-plugin: shell
4497:id: power-management/tickless_idle
4532-requires: cpuinfo.type not in ('arm', 'aarch64')
4581-_description: Check to see if CONFIG_NO_HZ is set in the kernel (this is just a simple regression check)

Ran it a few minutes ago and it did work, as Zygmunt says. That said, to avoid spurious issues, I'll change it.

[lp:~bladernr/checkbox/1330998-tickless-idle-not-on-arm]

3080. By Jeff Lane  on 2014-06-17

power-management.txt.in - changed requires for tickelss idle from a 'not in' to an 'in' to avoid issues with matching

[Jeff Lane  (bladernr)]

Changed it per discussion on IRC

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Daniel Manrique (roadmr)]

+1, thanks

review: Approve

=== modified file 'providers/plainbox-provider-checkbox/jobs/power-management.txt.in'
--- providers/plainbox-provider-checkbox/jobs/power-management.txt.in	2014-05-09 16:53:32 +0000
+++ providers/plainbox-provider-checkbox/jobs/power-management.txt.in	2014-06-17 15:31:45 +0000
@@ -145,6 +145,7 @@
 
 plugin: shell
 id: power-management/tickless_idle
+requires: cpuinfo.type in ('i386', 'amd64', 'ppc64el')
 _description: Check to see if CONFIG_NO_HZ is set in the kernel (this is just a simple regression check)
 command:
  zgrep 'CONFIG_NO_HZ=y' /boot/config-`uname -r` >/dev/null 2>&1 || ( echo "WARNING: Tickless Idle is NOT set" >&2 && exit 1 )