Merge lp:~bladernr/checkbox/1291664-removable-storage-traceback-on-ro-usb into lp:checkbox
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 2782 |
Merged at revision: | 2783 |
Proposed branch: | lp:~bladernr/checkbox/1291664-removable-storage-traceback-on-ro-usb |
Merge into: | lp:checkbox |
Diff against target: |
27 lines (+6/-0) 2 files modified
checkbox-old/CHANGELOG (+2/-0) checkbox-old/scripts/removable_storage_test (+4/-0) |
To merge this branch: | bzr merge lp:~bladernr/checkbox/1291664-removable-storage-traceback-on-ro-usb |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Jeff Lane | Needs Resubmitting | ||
Review via email: mp+210712@code.launchpad.net |
Description of the change
Fixes a condition where a write-protected USB device (or probably any WP device) causes the removable_
Write protected USB devices (and maybe others) cause an IOError in a section where they weren't caught.
Now we catch them
I've tried this on two servers that have embedded USB storage that is write protected, and this resolved the issue on both.
To post a comment you must log in.
I think this is a bit eager to jump to conclusions. We can check if the device is read only but we shouldn't treat *all* IOErrors as the device being read only. If you reword the error message to:
+ logging.error("I/O error accessing the device %s", dest)
I will gladly merge it.