Merge lp:~bladernr/checkbox/1188284-fix-s3-s4-30cycle-deps into lp:checkbox
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Approved by: | Daniel Manrique |
Approved revision: | 2167 |
Merged at revision: | 2167 |
Proposed branch: | lp:~bladernr/checkbox/1188284-fix-s3-s4-30cycle-deps |
Merge into: | lp:checkbox |
Diff against target: |
39 lines (+9/-2) 2 files modified
checkbox-old/debian/changelog (+3/-0) checkbox-old/jobs/stress.txt.in (+6/-2) |
To merge this branch: | bzr merge lp:~bladernr/checkbox/1188284-fix-s3-s4-30cycle-deps |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+167820@code.launchpad.net |
Description of the change
With this, the 30 cycle S3 and S4 tests will only run if the single cycle S3 and S4 tests have run and passed. If we can't successfully do a single cycle of each (The tests are manual and only fail if the system doesn't actually suspend/hibernate and resume) there's no point in running the 30 cycle tests.
When we do run them, what happens is the tester wastes time rebooting a system expected to fail, and clicking through checkbox to get passed the failing 30 cycle tests.
To post a comment you must log in.
I think this hadn't been done before because we had the stress tests on a separate whitelist, so we didn't want to add the single-test dependency to that list.
Anyway, this looks good, +1, thanks!