Merge lp:~bladernr/checkbox/1155619-fix-exit-io-error into lp:checkbox
Proposed by
Jeff Lane
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel Manrique | ||||
Approved revision: | 2064 | ||||
Merged at revision: | 2064 | ||||
Proposed branch: | lp:~bladernr/checkbox/1155619-fix-exit-io-error | ||||
Merge into: | lp:checkbox | ||||
Diff against target: |
115 lines (+27/-10) 4 files modified
checkbox/lib/fifo.py (+6/-1) debian/changelog (+4/-0) plugins/lock_prompt.py (+16/-8) plugins/persist_info.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~bladernr/checkbox/1155619-fix-exit-io-error | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+159889@code.launchpad.net |
Description of the change
First: Fixed the I/O Available message. We weren't properly releasing the lock, so I added bits to use the glock release function at shutdown.
This exposed a different issue where the input and output fifo file descriptors were coming back as invalid on close, because for some reason, those FDs were closed out before the close() function of fifo.py was called... so I just wrapped those to catch the exception and comment on it.
This all occurs RIGHT at shutdown so it's all just garbage collection.
To post a comment you must log in.
+1, thanks! Great work tracking this down.