Merge lp:~bladernr/checkbox/1087777-remove-perl-from-unity_support_test-jobs into lp:checkbox

[Jeff Lane ]

removed the unnecessary perl wrappings used to strip ansi codes from output of unity_support_test. Instead they pipe through ansi_parser like other jobs that produce ansi coded output on stdout.

[Zygmunt Krynicki (zyga)]

Thank you for removing perl!

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-12-04 10:01:21 +0000
+++ debian/changelog	2012-12-07 17:03:23 +0000
@@ -19,6 +19,9 @@
   * jobs/suspend.txt.in - fixed cycle_resolutions_after_suspend_auto so that it
     properly depends on suspend_advanced_auto rather than suspend_advanced
     (LP: #1071605)
+  * jobs/graphics.txt.in - removed perl wrappings from tests using
+    unity_support_test. They should pipe through ansi_parser like other jobs.
+    (LP: #1087777)
 
   [Sylvain Pineau]
   * jobs/info.txt.in: Fixed the requirement of info/touchpad_driver.

=== modified file 'jobs/graphics.txt.in'
--- jobs/graphics.txt.in	2012-11-27 12:00:12 +0000
+++ jobs/graphics.txt.in	2012-12-07 17:03:23 +0000
@@ -121,14 +121,14 @@
 name: graphics/compiz_check
 requires: package.name == 'nux-tools'
 command:
- perl -e '$a=`/usr/lib/nux/unity_support_test -c -p`;$a=~s/\e\[[\d;]*m//g;print $a;exit($? ? 1:0)'
+ /usr/lib/nux/unity_support_test -c -p | ansi_parser
 _description: Check that hardware is able to run compiz
 
 plugin: shell
 name: graphics/unity-support
 requires: package.name == 'nux-tools'
 command:
- perl -e '$a=`/usr/lib/nux/unity_support_test -p`;$a=~s/\e\[[\d;]*m//g;print $a;exit($? ? 1:0)'
+ /usr/lib/nux/unity_support_test -p | ansi_parser
 _description: Check that hardware is able to run Unity 3D
 
 plugin: user-verify