Merge lp:~bladernr/checkbox/1078837-update-alsa_info into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 1825
Merged at revision: 1825
Proposed branch: lp:~bladernr/checkbox/1078837-update-alsa_info
Merge into: lp:checkbox
Diff against target: 135 lines (+23/-10)
2 files modified
debian/changelog (+3/-1)
scripts/alsa_info (+20/-9)
To merge this branch: bzr merge lp:~bladernr/checkbox/1078837-update-alsa_info
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+134503@code.launchpad.net

Description of the change

Simple update of alsa_info script to the latest version from alsa.org.

Also, updated changelog using dch -m. lets see if THAT avoids conflicts.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Heh, the maintainer line was still modified, but I see no conflicts so hopefully it's safe to approve this and let Tarmac handle things. +1 on updating alsa_info, the changes seem pretty minimal anyway. Thanks!

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

ah HAH! dch -t seems to do the job without changing the maintainer line at all.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-13 14:36:37 +0000
3+++ debian/changelog 2012-11-15 16:29:25 +0000
4@@ -145,8 +145,10 @@
5 less than minvol, not when equal to either. (LP: #1077008)
6 * Added root user requirement to all jobs using removable storage test
7 (LP: #1014813)
8+ * scripts/alsa_info - updated script to latest version available
9+ (LP: #1078837)
10
11- -- Jeff Lane <jeff@ubuntu.com> Wed, 07 Nov 2012 17:33:46 -0500
12+ -- Jeff Lane <jeff@ubuntu.com> Thu, 15 Nov 2012 10:50:03 -0500
13
14 checkbox (0.14.6) quantal; urgency=low
15
16
17=== modified file 'scripts/alsa_info'
18--- scripts/alsa_info 2012-06-01 20:15:44 +0000
19+++ scripts/alsa_info 2012-11-15 16:29:25 +0000
20@@ -1,6 +1,6 @@
21 #!/bin/bash
22
23-SCRIPT_VERSION=0.4.60
24+SCRIPT_VERSION=0.4.61
25 CHANGELOG="http://www.alsa-project.org/alsa-info.sh.changelog"
26
27 #################################################################################
28@@ -111,7 +111,7 @@
29
30 withaplay() {
31 echo "!!Aplay/Arecord output" >> $FILE
32- echo "!!------------" >> $FILE
33+ echo "!!--------------------" >> $FILE
34 echo "" >> $FILE
35 echo "APLAY" >> $FILE
36 echo "" >> $FILE
37@@ -149,7 +149,7 @@
38
39 withalsactl() {
40 echo "!!Alsactl output" >> $FILE
41- echo "!!-------------" >> $FILE
42+ echo "!!--------------" >> $FILE
43 echo "" >> $FILE
44 exe=""
45 if [ -x /usr/sbin/alsactl ]; then
46@@ -244,7 +244,7 @@
47
48 withdmesg() {
49 echo "!!ALSA/HDA dmesg" >> $FILE
50- echo "!!------------------" >> $FILE
51+ echo "!!--------------" >> $FILE
52 echo "" >> $FILE
53 dmesg | grep -C1 -E 'ALSA|HDA|HDMI|sound|hda.codec|hda.intel' >> $FILE
54 echo "" >> $FILE
55@@ -416,6 +416,7 @@
56 PAINST=$(which pulseaudio 2>/dev/null| sed 's|^[^/]*||' 2>/dev/null)
57 ARTSINST=$(which artsd 2>/dev/null| sed 's|^[^/]*||' 2>/dev/null)
58 JACKINST=$(which jackd 2>/dev/null| sed 's|^[^/]*||' 2>/dev/null)
59+ROARINST=$(which roard 2>/dev/null| sed 's|^[^/]*||' 2>/dev/null)
60 DMIDECODE=$(which dmidecode 2>/dev/null| sed 's|^[^/]*||' 2>/dev/null)
61
62 #Check for DMI data
63@@ -424,10 +425,12 @@
64 DMI_SYSTEM_MANUFACTURER=$(cat /sys/class/dmi/id/sys_vendor 2>/dev/null)
65 DMI_SYSTEM_PRODUCT_NAME=$(cat /sys/class/dmi/id/product_name 2>/dev/null)
66 DMI_SYSTEM_PRODUCT_VERSION=$(cat /sys/class/dmi/id/product_version 2>/dev/null)
67+ DMI_SYSTEM_FIRMWARE_VERSION=$(cat /sys/class/dmi/id/bios_version 2>/dev/null)
68 elif [ -x $DMIDECODE ]; then
69 DMI_SYSTEM_MANUFACTURER=$($DMIDECODE -s system-manufacturer 2>/dev/null)
70 DMI_SYSTEM_PRODUCT_NAME=$($DMIDECODE -s system-product-name 2>/dev/null)
71 DMI_SYSTEM_PRODUCT_VERSION=$($DMIDECODE -s system-version 2>/dev/null)
72+ DMI_SYSTEM_FIRMWARE_VERSION=$($DMIDECODE -s bios-version 2>/dev/null)
73 fi
74
75 cat /proc/asound/modules 2>/dev/null|awk {'print $2'}>$TEMPDIR/alsamodules.tmp
76@@ -469,6 +472,7 @@
77 echo "Manufacturer: $DMI_SYSTEM_MANUFACTURER" >> $FILE
78 echo "Product Name: $DMI_SYSTEM_PRODUCT_NAME" >> $FILE
79 echo "Product Version: $DMI_SYSTEM_PRODUCT_VERSION" >> $FILE
80+echo "Firmware Version: $DMI_SYSTEM_FIRMWARE_VERSION" >> $FILE
81 echo "" >> $FILE
82 echo "" >> $FILE
83 echo "!!Kernel Information" >> $FILE
84@@ -526,7 +530,14 @@
85 echo " Running - $JACKRUNNING" >> $FILE
86 echo "" >> $FILE
87 fi
88-if [[ -z "$PAINST" && -z "$ESDINST" && -z "$ARTSINST" && -z "$JACKINST" ]];then
89+if [[ -n $ROARINST ]];then
90+[[ `pgrep '^(.*/)?roard$'` ]] && ROARRUNNING="Yes" || ROARRUNNING="No"
91+echo "RoarAudio:" >> $FILE
92+echo " Installed - Yes ($ROARINST)" >> $FILE
93+echo " Running - $ROARRUNNING" >> $FILE
94+echo "" >> $FILE
95+fi
96+if [[ -z "$PAINST" && -z "$ESDINST" && -z "$ARTSINST" && -z "$JACKINST" && -z "$ROARINST" ]];then
97 echo "No sound servers found." >> $FILE
98 echo "" >> $FILE
99 fi
100@@ -544,7 +555,7 @@
101 echo "" >> $FILE
102 echo "" >> $FILE
103 echo "!!Advanced information - PCI Vendor/Device/Subsystem ID's" >> $FILE
104-echo "!!--------------------------------------------------------" >> $FILE
105+echo "!!-------------------------------------------------------" >> $FILE
106 echo "" >> $FILE
107 lspci -vvn |grep -A1 040[1-3] >> $FILE
108 echo "" >> $FILE
109@@ -563,7 +574,7 @@
110 if [ -d "$SYSFS" ]
111 then
112 echo "!!Loaded sound module options" >> $FILE
113-echo "!!--------------------------" >> $FILE
114+echo "!!---------------------------" >> $FILE
115 echo "" >> $FILE
116 for mod in `cat /proc/asound/modules|awk {'print $2'}`;do
117 echo "!!Module: $mod" >> $FILE
118@@ -591,7 +602,7 @@
119 if [ -s "$TEMPDIR/alsa-ac97.tmp" ]
120 then
121 echo "!!AC97 Codec information" >> $FILE
122- echo "!!---------------------------" >> $FILE
123+ echo "!!----------------------" >> $FILE
124 echo "--startcollapse--" >> $FILE
125 echo "" >> $FILE
126 cat $TEMPDIR/alsa-ac97.tmp >> $FILE
127@@ -605,7 +616,7 @@
128 if [ -s "$TEMPDIR/alsa-usbmixer.tmp" ]
129 then
130 echo "!!USB Mixer information" >> $FILE
131- echo "!!---------------------------" >> $FILE
132+ echo "!!---------------------" >> $FILE
133 echo "--startcollapse--" >> $FILE
134 echo "" >> $FILE
135 cat $TEMPDIR/alsa-usbmixer.tmp >> $FILE

Subscribers

People subscribed via source and target branches