Merge lp:~bladernr/checkbox/1065983-info-eth0-not-initiated into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2085
Merged at revision: 2087
Proposed branch: lp:~bladernr/checkbox/1065983-info-eth0-not-initiated
Merge into: lp:checkbox
Diff against target: 25 lines (+3/-1)
2 files modified
debian/changelog (+2/-0)
jobs/networking.txt.in (+1/-1)
To merge this branch: bzr merge lp:~bladernr/checkbox/1065983-info-eth0-not-initiated
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+161006@code.launchpad.net

Description of the change

Fixed a longstanding and annoying issue where networking/info_* jobs were not being run, instead being left as "uninitiated"

See related bug for full details.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-25 19:11:18 +0000
3+++ debian/changelog 2013-04-25 20:28:26 +0000
4@@ -21,6 +21,8 @@
5 fails. (LP: #1169922)
6 * scripts/bluetooth_test: test no longer generates odd Broken Pipe error when
7 the dpkg bit verifies obexftp is installed (LP: #1169488)
8+ * jobs/networking.txt.in: fixed networking/info jobs that were not being run
9+ because $output was being resolved too early (LP: #1065983)
10
11 [ Daniel Manrique ]
12 * scripts/alsa_record_playback: Replaced alsasrc with autoaudiosrc
13
14=== modified file 'jobs/networking.txt.in'
15--- jobs/networking.txt.in 2013-04-25 19:11:18 +0000
16+++ jobs/networking.txt.in 2013-04-25 20:28:26 +0000
17@@ -29,7 +29,7 @@
18 STEPS:
19 1. Please verify the following information for NIC $2
20 INFO:
21- $output
22+ \$output
23 VERIFICATION:
24 Is this correct?
25 EOF

Subscribers

People subscribed via source and target branches