Checkbox

Merge lp:~bladernr/checkbox/1031944 into lp:checkbox

  1. 1031944
  2. Merge into trunk
Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1544
Proposed branch: lp:~bladernr/checkbox/1031944
Merge into: lp:checkbox
Diff against target: 28 lines (+6/-1)
2 files modified
debian/changelog (+5/-1)
jobs/cpu.txt.in (+1/-0)
To merge this branch: bzr merge lp:~bladernr/checkbox/1031944
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+117821@code.launchpad.net

Description of the change

added a depends to cpu/scaling_test-log-attach to ensure it runs before cpu/scaling_test. I noticed results don't have the actual log, but they are indicating an FWTS medium failure in cpufreq that could be causing cpu/scaling_test to result in a false pass.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Makes sense, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-07-31 16:50:46 +0000
3+++ debian/changelog 2012-08-02 00:25:23 +0000
4@@ -40,7 +40,11 @@
5 [Marc Tardif]
6 * Escaping encoded strings in udevadm output (LP: #1025381)
7
8- -- Daniel Manrique <roadmr@ubuntu.com> Wed, 25 Jul 2012 15:30:11 -0400
9+ [Jeff Lane]
10+ * jobs/cpu.txt.in: added a depends to cpu/scaling_test-log-attach to ensure
11+ that job does not run until afte cpu/scaling_test (LP: #1031994)
12+
13+ -- Jeff Lane <jeff@ubuntu.com> Wed, 01 Aug 2012 20:22:12 -0400
14
15 checkbox (0.14.2) quantal; urgency=low
16
17
18=== modified file 'jobs/cpu.txt.in'
19--- jobs/cpu.txt.in 2012-07-11 01:21:11 +0000
20+++ jobs/cpu.txt.in 2012-08-02 00:25:23 +0000
21@@ -10,6 +10,7 @@
22
23 plugin: attachment
24 name: cpu/scaling_test-log-attach
25+depends: cpu/scaling_test
26 command: [[ -e ${CHECKBOX_DATA}/scaling_test.log ]] && cat ${CHECKBOX_DATA}/scaling_test.log
27 _description:
28 Attaches the log generated by cpu/scaling_test to the results

Subscribers

People subscribed via source and target branches