Merge lp:~bladernr/checkbox/1014813-removable-storage-root-perms into lp:checkbox

[Jeff Lane ]

Several instances of tests using removable_storage_test failed because of lack of root level permissions. Some of the jobs that use removable_storage_test already had 'user: root' specified. I've gone through and made all the remaining removable_storage_test jobs do the same.

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Zygmunt Krynicki (zyga)]

Attempt to merge into lp:checkbox failed due to conflicts:

text conflict in debian/changelog

[Jeff Lane  (bladernr)]

Resolved a changelog conflict

review: Needs Resubmitting

[Sylvain Pineau (sylvain-pineau)]

Approved

review: Approve

[Zygmunt Krynicki (zyga)]

Attempt to merge into lp:checkbox failed due to conflicts:

text conflict in debian/changelog

[Jeff Lane  (bladernr)]

I'm just going to stop updating the changelog... >:(

[lp:~bladernr/checkbox/1014813-removable-storage-root-perms]

1822. By Jeff Lane  on 2012-11-13

Fix changelog ... again.

[Jeff Lane  (bladernr)]

I fixed this EXACT SAME changelog conflict already. Then I pushed that and it conflicted again... it is now fixed, again.

review: Needs Resubmitting

[Zygmunt Krynicki (zyga)]

In such case just accept yourself, we'll be happier :)

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-11-13 08:35:25 +0000
+++ debian/changelog	2012-11-13 14:39:25 +0000
@@ -143,6 +143,8 @@
     real benefit and fails about 100% of the time. (LP: #764376)
   * scrips/volume_test - script now only fails if volume is greater than maxvol or
     less than minvol, not when equal to either. (LP: #1077008)
+  * Added root user requirement to all jobs using removable storage test 
+    (LP: #1014813)
 
  -- Jeff Lane <[e-mail]>  Wed, 07 Nov 2012 17:33:46 -0500
 

=== modified file 'jobs/esata.txt.in'
--- jobs/esata.txt.in	2012-10-27 10:33:23 +0000
+++ jobs/esata.txt.in	2012-11-13 14:39:25 +0000
@@ -14,6 +14,7 @@
 
 plugin: shell
 name: esata/storage-test
+user: root
 depends: esata/insert
 command: removable_storage_test ata_serial_esata
 _description:

=== modified file 'jobs/firewire.txt.in'
--- jobs/firewire.txt.in	2012-10-27 10:33:23 +0000
+++ jobs/firewire.txt.in	2012-11-13 14:39:25 +0000
@@ -14,6 +14,7 @@
 
 plugin: shell
 name: firewire/storage-test
+user: root
 depends: firewire/insert
 command: removable_storage_test firewire
 _description:

=== modified file 'jobs/mediacard.txt.in'
--- jobs/mediacard.txt.in	2012-10-27 10:33:23 +0000
+++ jobs/mediacard.txt.in	2012-11-13 14:39:25 +0000
@@ -16,6 +16,7 @@
 plugin: shell
 name: mediacard/mmc-storage
 depends: mediacard/mmc-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/mmc-insert
@@ -55,6 +56,7 @@
 plugin: shell
 name: mediacard/mmc-storage-after-suspend
 depends: mediacard/mmc-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/mmc-insert-after-suspend test
@@ -93,6 +95,7 @@
 plugin: shell
 name: mediacard/sd-storage
 depends: mediacard/sd-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sd-insert
@@ -132,6 +135,7 @@
 plugin: shell
 name: mediacard/sd-storage-after-suspend
 depends: mediacard/sd-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sd-insert-after-suspend test
@@ -180,6 +184,7 @@
 plugin: shell
 name: mediacard/sdhc-storage
 depends: mediacard/sdhc-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sdhc-insert
@@ -219,6 +224,7 @@
 plugin: shell
 name: mediacard/sdhc-storage-after-suspend
 depends: mediacard/sdhc-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sdhc-insert-after-suspend test
@@ -257,6 +263,7 @@
 plugin: shell
 name: mediacard/cf-storage
 depends: mediacard/cf-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/cf-insert
@@ -296,6 +303,7 @@
 plugin: shell
 name: mediacard/cf-storage-after-suspend
 depends: mediacard/cf-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/cf-insert-after-suspend test
@@ -334,6 +342,7 @@
 plugin: shell
 name: mediacard/sdxc-storage
 depends: mediacard/sdxc-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sdxc-insert
@@ -373,6 +382,7 @@
 plugin: shell
 name: mediacard/sdxc-storage-after-suspend
 depends: mediacard/sdxc-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/sdxc-insert-after-suspend test
@@ -411,6 +421,7 @@
 plugin: shell
 name: mediacard/ms-storage
 depends: mediacard/ms-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/ms-insert
@@ -450,6 +461,7 @@
 plugin: shell
 name: mediacard/ms-storage-after-suspend
 depends: mediacard/ms-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/ms-insert-after-suspend test
@@ -488,6 +500,7 @@
 plugin: shell
 name: mediacard/msp-storage
 depends: mediacard/msp-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/msp-insert
@@ -527,6 +540,7 @@
 plugin: shell
 name: mediacard/msp-storage-after-suspend
 depends: mediacard/msp-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/msp-insert-after-suspend test
@@ -565,6 +579,7 @@
 plugin: shell
 name: mediacard/xd-storage
 depends: mediacard/xd-insert
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/xd-insert
@@ -604,6 +619,7 @@
 plugin: shell
 name: mediacard/xd-storage-after-suspend
 depends: mediacard/xd-insert-after-suspend
+user: root
 command: removable_storage_test --memorycard sdio usb scsi
 _description:
  This test is automated and executes after the mediacard/xd-insert-after-suspend test

=== modified file 'jobs/usb.txt.in'
--- jobs/usb.txt.in	2012-10-29 21:43:57 +0000
+++ jobs/usb.txt.in	2012-11-13 14:39:25 +0000
@@ -100,6 +100,7 @@
 plugin: manual
 name: usb/storage-transfer
 depends: usb/insert
+user: root
 command: removable_storage_test usb
 _description:
  PURPOSE:
@@ -117,6 +118,7 @@
 requires:
  usb.usb3 == 'supported'
 depends: usb3/insert
+user: root
 command: removable_storage_test -m 500000000 -p 7 usb
 _description:
  PURPOSE:
@@ -132,6 +134,7 @@
 plugin: shell
 name: usb/storage-automated
 depends: usb/insert
+user: root
 command: removable_storage_test usb
 _description:
  This test is automated and executes after the usb/insert test is run.
@@ -141,6 +144,7 @@
 requires:
  usb.usb3 == 'supported'
 depends: usb3/insert
+user: root
 command: removable_storage_test -m 500000000 -p 7 usb
 _description:
  This test is automated and executes after the usb3/insert test is run.