Merge lp:~black-perl/postorius/fix-postorius into lp:postorius

Proposed by Ankush Sharma on 2015-03-04
Status: Merged
Merged at revision: 205
Proposed branch: lp:~black-perl/postorius/fix-postorius
Merge into: lp:postorius
Diff against target: 11 lines (+2/-0)
1 file modified
src/postorius/management/commands/mmclient.py (+2/-0)
To merge this branch: bzr merge lp:~black-perl/postorius/fix-postorius
Reviewer Review Type Date Requested Status
Florian Fuchs 2015-03-04 Approve on 2015-03-10
Review via email: mp+251761@code.launchpad.net

Description of the change

Added the `client` to the globals() dictionary before invoking the python interpreter. This would fix up things for the systems on which ipython is not present and therefore default python interpreter is invoked.

To post a comment you must log in.
Florian Fuchs (flo-fuchs) wrote :

Hi Ankush,

thanks for this fix. Tested, approved, merged. ;-)

Florian

review: Approve
Ankush Sharma (black-perl) wrote :

Hello Florian,

Thanks for giving time to it. It would be good if I can have your view on these https://bugs.launchpad.net/postorius/+bug/1428543 and https://bugs.launchpad.net/postorius/+bug/1429366 sometime later. I am working on to fix the latter one.

Ankush

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/management/commands/mmclient.py'
2--- src/postorius/management/commands/mmclient.py 2015-02-09 14:35:44 +0000
3+++ src/postorius/management/commands/mmclient.py 2015-03-04 15:37:52 +0000
4@@ -45,5 +45,7 @@
5 console_fn = shell.interact
6 # connect to mailmanclient
7 client = utils.get_client()
8+ # Putting client back in the global scope
9+ globals()['client'] = client
10 # run the interpreter
11 console_fn()

Subscribers

People subscribed via source and target branches