Zim

Merge lp:~bkidwell/zim/win32-build-0.63-fixes into lp:~jaap.karssenberg/zim/pyzim

Proposed by Brendan Kidwell
Status: Merged
Merged at revision: 776
Proposed branch: lp:~bkidwell/zim/win32-build-0.63-fixes
Merge into: lp:~jaap.karssenberg/zim/pyzim
Diff against target: 96 lines (+21/-22)
4 files modified
setup.py (+3/-0)
windows/README-BUILD-win32.txt (+9/-22)
windows/build_win32.py (+8/-0)
windows/create-zim-setup.nsi (+1/-0)
To merge this branch: bzr merge lp:~bkidwell/zim/win32-build-0.63-fixes
Reviewer Review Type Date Requested Status
Jaap Karssenberg Pending
Review via email: mp+263861@code.launchpad.net

Description of the change

Windows build: exclude system DNSAPI.DLL from installer to fix conflict; better compression in installer; support GtkSourceView.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2014-10-14 05:42:43 +0000
3+++ setup.py 2015-07-06 06:07:34 +0000
4@@ -354,6 +354,9 @@
5 "ascii": 1,
6 "bundle_files": 3,
7 "packages": ["encodings", "cairo", "atk", "pangocairo", "zim"],
8+ "dll_excludes": {
9+ "DNSAPI.DLL"
10+ }
11 }
12 }
13 }
14
15=== modified file 'windows/README-BUILD-win32.txt'
16--- windows/README-BUILD-win32.txt 2012-04-04 00:03:31 +0000
17+++ windows/README-BUILD-win32.txt 2015-07-06 06:07:34 +0000
18@@ -18,36 +18,23 @@
19 Requirements
20 ------------
21
22-1. Install Python 2.6 or greater for Windows from
23+1. Install Python 2.7 for Windows from
24
25 http://www.python.org/download/
26
27- Note: Python version must be 2.6 or greater, but less than 3.0
28+ Note: Zim has not yet been ported to Python 3.
29
30 2. Install the py2exe library from
31
32 http://sourceforge.net/projects/py2exe/files/
33
34-3. Download GTK+ Bundle from
35-
36- http://ftp.gnome.org/pub/gnome/binaries/win32/gtk+/2.24/
37-
38- Or a newer version if one exists. Extract this Zip file to a
39- convenient place such as
40-
41- C:\Program Files (x86)\Common Files\GTK+ Bundle
42-
43-4. Install PyCairo, PyGObject, and PyGTK from
44-
45- http://ftp.gnome.org/pub/GNOME/binaries/win32/pycairo/[newest version]/pycairo-VERSION.win32-pyVER.msi
46- http://ftp.gnome.org/pub/GNOME/binaries/win32/pygobject/[newest version]/pygobject-VERSION.win32-pyVER.msi
47- http://ftp.gnome.org/pub/GNOME/binaries/win32/pygtk/[newest version]/pygtk-VERSION.win32-pyVER.msi
48-
49- Make sure that the Python version matches the one you're using, and
50- that you don't download a pygtk library with a version newer than
51- the bundle from the previous step.
52-
53-5. Jpeg for Windows
54+3. Install PyGTK All-in-One from
55+
56+ http://ftp.gnome.org/pub/GNOME/binaries/win32/pygtk/2.24/pygtk-all-in-one-2.24.2.win32-py2.7.msi
57+
58+ Be sure to include "PyGTKSourceView" when you run the installer.
59+
60+4. Jpeg for Windows
61
62 http://gnuwin32.sourceforge.net/packages/jpeg.htm
63
64
65=== modified file 'windows/build_win32.py'
66--- windows/build_win32.py 2014-10-10 19:28:06 +0000
67+++ windows/build_win32.py 2015-07-06 06:07:34 +0000
68@@ -32,8 +32,16 @@
69
70 # Find GTK 'runtime' folder
71 for libdir in os.environ["PATH"].split(path.pathsep):
72+ # Look for GTK bin folder in a $PATH element
73 if path.exists(path.join(libdir, "libgtk-win32-2.0-0.dll")):
74 GTK_ROOT = path.dirname(libdir)
75+ break
76+ # Look for GTK under Python's site-packages folder
77+ if path.exists(path.join(libdir, r"Lib\site-packages\gtk-2.0\runtime\bin", "libgtk-win32-2.0-0.dll")):
78+ GTK_ROOT = path.join(libdir, r"Lib\site-packages\gtk-2.0\runtime")
79+ break
80+if not GTK_ROOT:
81+ raise RuntimeError("Can't find GTK")
82
83 # Parse '__version__' out of zim package since simply importing __version__ from zim fails as of 0.61
84 f = open("zim/__init__.py", "r")
85
86=== modified file 'windows/create-zim-setup.nsi'
87--- windows/create-zim-setup.nsi 2012-01-16 06:17:13 +0000
88+++ windows/create-zim-setup.nsi 2015-07-06 06:07:34 +0000
89@@ -13,6 +13,7 @@
90 InstallDir "$PROGRAMFILES\Zim Desktop Wiki"
91 InstallDirRegKey HKLM "Software\${APPNAME}" ""
92 OutFile "..\dist\Zim-setup-${VER}_${BUILDDATE}.exe"
93+SetCompressor /SOLID lzma
94
95 ; Modern interface settings
96 !include "MUI.nsh"