Merge lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1 into lp:ubuntu/raring/eglibc
Proposed by
Benjamin Kerensa
on 2012-11-23
| Status: | Rejected |
|---|---|
| Rejected by: | Stéphane Graber on 2012-11-30 |
| Proposed branch: | lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1 |
| Merge into: | lp:ubuntu/raring/eglibc |
| Diff against target: |
53 lines (+10/-4) 2 files modified
debian/changelog (+6/-0) debian/control (+4/-4) |
| To merge this branch: | bzr merge lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Conrad | Disapprove on 2012-11-30 | ||
| Ubuntu branches | 2012-11-23 | Pending | |
|
Review via email:
|
|||
Description of the Change
add ${misc:Depends}
To post a comment you must log in.
| Daniel Holbach (dholbach) wrote : | # |
| Adam Conrad (adconrad) wrote : | # |
There's no need for eglibc to have misc:Depends sprinkled all over its control file, we hand-craft our dependencies intentionally, and guard our use of debconf so it's not required as a depdency (thus keeping debconf out of the Essential set).
review:
Disapprove
Unmerged revisions
- 309. By Benjamin Kerensa on 2012-11-23
-
Add depends
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for your work on this. Do you think it would be possible for you to forward the change to Debian instead? It would make things a lot easier for us. You should be able to just run 'submittodebian' from the source tree to submit it there. http://