Merge lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1 into lp:ubuntu/raring/eglibc

Proposed by Benjamin Kerensa
Status: Rejected
Rejected by: Stéphane Graber
Proposed branch: lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1
Merge into: lp:ubuntu/raring/eglibc
Diff against target: 53 lines (+10/-4)
2 files modified
debian/changelog (+6/-0)
debian/control (+4/-4)
To merge this branch: bzr merge lp:~bkerensa/ubuntu/raring/eglibc/depends-fix1
Reviewer Review Type Date Requested Status
Adam Conrad (community) Disapprove
Ubuntu branches Pending
Review via email: mp+135995@code.launchpad.net

Description of the change

add ${misc:Depends}

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks for your work on this. Do you think it would be possible for you to forward the change to Debian instead? It would make things a lot easier for us. You should be able to just run 'submittodebian' from the source tree to submit it there. http://developer.ubuntu.com/packaging/html/fixing-a-bug-example.html has some additional information as well.

Revision history for this message
Adam Conrad (adconrad) wrote :

There's no need for eglibc to have misc:Depends sprinkled all over its control file, we hand-craft our dependencies intentionally, and guard our use of debconf so it's not required as a depdency (thus keeping debconf out of the Essential set).

review: Disapprove

Unmerged revisions

309. By Benjamin Kerensa

Add depends

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-03 23:55:41 +0000
3+++ debian/changelog 2012-11-23 23:52:22 +0000
4@@ -1,3 +1,9 @@
5+eglibc (2.15-0ubuntu21) raring; urgency=low
6+
7+ * debian/control: add ${misc:Depends} as needed.
8+
9+ -- Benjamin Kerensa <bkerensa@ubuntu.com> Fri, 23 Nov 2012 15:50:06 -0800
10+
11 eglibc (2.15-0ubuntu20) quantal; urgency=low
12
13 * Backport fixes for dbl-64 and ldbl-128 issues (LP: #1000498)
14
15=== modified file 'debian/control'
16--- debian/control 2012-09-11 15:40:27 +0000
17+++ debian/control 2012-11-23 23:52:22 +0000
18@@ -140,7 +140,7 @@
19 Section: libs
20 Priority: required
21 Multi-Arch: same
22-Depends: libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
23+Depends: ${misc:Depends}, libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
24 Recommends: libc0.1-i686 [kfreebsd-i386], libc0.3-i686 [hurd-i386]
25 Suggests: glibc-doc, debconf | debconf-2.0, locales [!hurd-i386]
26 Provides: ${locale-compat:Depends}, libc6-i686 [i386], libc6-sparcv9b [sparc sparc64], libc6-armel [armel], libc6-armhf [armhf]
27@@ -229,7 +229,7 @@
28 Section: libs
29 Priority: required
30 Multi-Arch: same
31-Depends: libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
32+Depends: ${misc:Depends}, libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
33 Recommends: libc0.1-i686 [kfreebsd-i386], libc0.3-i686 [hurd-i386]
34 Suggests: glibc-doc, debconf | debconf-2.0, locales [!hurd-i386]
35 Provides: ${locale-compat:Depends}, libc6-i686 [i386], libc6-sparcv9b [sparc sparc64], libc6-armel [armel], libc6-armhf [armhf]
36@@ -318,7 +318,7 @@
37 Section: libs
38 Priority: required
39 Multi-Arch: same
40-Depends: libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
41+Depends: ${misc:Depends}, libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
42 Recommends: libc0.1-i686 [kfreebsd-i386], libc0.3-i686 [hurd-i386]
43 Suggests: glibc-doc, debconf | debconf-2.0, locales [!hurd-i386]
44 Provides: ${locale-compat:Depends}, libc6-i686 [i386], libc6-sparcv9b [sparc sparc64], libc6-armel [armel], libc6-armhf [armhf]
45@@ -407,7 +407,7 @@
46 Section: libs
47 Priority: required
48 Multi-Arch: same
49-Depends: libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
50+Depends: ${misc:Depends}, libc-bin (= ${binary:Version}), hurd (>= 20070606-1+SVN) [hurd-i386], libgcc1 [!hppa !m68k], libgcc2 [m68k], libgcc4 [hppa], tzdata
51 Recommends: libc0.1-i686 [kfreebsd-i386], libc0.3-i686 [hurd-i386]
52 Suggests: glibc-doc, debconf | debconf-2.0, locales [!hurd-i386]
53 Provides: ${locale-compat:Depends}, libc6-i686 [i386], libc6-sparcv9b [sparc sparc64], libc6-armel [armel], libc6-armhf [armhf]

Subscribers

People subscribed via source and target branches