Merge lp:~bkerensa/ubuntu/raring/eggdrop/depends-fix1 into lp:ubuntu/raring/eggdrop

Proposed by Benjamin Kerensa
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~bkerensa/ubuntu/raring/eggdrop/depends-fix1
Merge into: lp:ubuntu/raring/eggdrop
Diff against target: 35 lines (+8/-2)
2 files modified
debian/changelog (+6/-0)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~bkerensa/ubuntu/raring/eggdrop/depends-fix1
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Ubuntu branches Pending
Review via email: mp+135992@code.launchpad.net

Description of the change

Added ${misc:Depends} to debian/control.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, is there any depends missing without those? Could you send the diff to the Debian BTS?

Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

I do not believe any missing dependencies exist with out it as I see no bugs suggesting people are running into issues but it is still something we should have in control?

I can send the diff to Debian BTS but I believe this is a locally maintained package otherwise I would have skipped the MP and just had it fixed upstream.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks for your work on this. Do you think it would be possible for you to forward the change to Debian instead? It would make things a lot easier for us. You should be able to just run 'submittodebian' from the source tree to submit it there. http://developer.ubuntu.com/packaging/html/fixing-a-bug-example.html has some additional information as well.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Benjamin: http://packages.qa.debian.org/e/eggdrop.html ... we have a diff but the package is coming from Debian and we like to keep diffs as small as possible in such case. I will sponsor your fix but please forward it to Debian as well

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-05-20 17:59:34 +0000
3+++ debian/changelog 2012-11-23 23:45:30 +0000
4@@ -1,3 +1,9 @@
5+eggdrop (1.6.19-1.2ubuntu6) raring; urgency=low
6+
7+ * debian/control: add ${misc:Depends} as needed.
8+
9+ -- Benjamin Kerensa <bkerensa@ubuntu.com> Fri, 23 Nov 2012 15:39:44 -0800
10+
11 eggdrop (1.6.19-1.2ubuntu5) quantal; urgency=low
12
13 * fix a bug in gcc-format-string-warnings.patch
14
15=== modified file 'debian/control'
16--- debian/control 2008-10-04 12:02:58 +0000
17+++ debian/control 2012-11-23 23:45:30 +0000
18@@ -9,7 +9,7 @@
19
20 Package: eggdrop
21 Architecture: any
22-Depends: ${shlibs:Depends}, eggdrop-data (= ${source:Version})
23+Depends: ${misc:Depends}, ${shlibs:Depends}, eggdrop-data (= ${source:Version})
24 Description: Advanced IRC Robot
25 Eggdrop is an IRC bot written in C, which sits on channels and takes
26 protective measures, such as preventing it from being taken over (in
27@@ -24,7 +24,7 @@
28
29 Package: eggdrop-data
30 Architecture: all
31-Replaces: eggdrop (>= 1.6.16-2)
32+Replaces: ${misc:Depends}, eggdrop (>= 1.6.16-2)
33 Description: Architecture independent files for eggdrop
34 This package contains all the files that eggdrop places on /usr/share.
35 These files are not specific to a single processor architecture once

Subscribers

People subscribed via source and target branches