Merge lp:~bkerensa/ubuntu/quantal/xorg-server/quantal-proposed-1104209 into lp:ubuntu/quantal/xorg-server
Proposed by
Benjamin Kerensa
Status: | Work in progress |
---|---|
Proposed branch: | lp:~bkerensa/ubuntu/quantal/xorg-server/quantal-proposed-1104209 |
Merge into: | lp:ubuntu/quantal/xorg-server |
Diff against target: |
365 lines (+305/-2) 8 files modified
debian/changelog (+25/-0) debian/patches/233-xf86events-valgrind.patch (+16/-0) debian/patches/234-composite-borderclip.patch (+48/-0) debian/patches/235-composite-tracking.diff (+78/-0) debian/patches/236-use-fbdev-for-poulsbo-oaktrail-medfield.patch (+88/-0) debian/patches/237-dix-set-the-device-transformation-matrix.patch (+42/-0) debian/patches/series (+5/-0) dix/getevents.c (+3/-2) |
To merge this branch: | bzr merge lp:~bkerensa/ubuntu/quantal/xorg-server/quantal-proposed-1104209 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington | Needs Fixing | ||
Ubuntu branches | Pending | ||
Review via email: mp+144824@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 248. By Benjamin Kerensa
-
add patch from upstream to fix screen crossings
- 247. By Timo Aaltonen
-
[ Maarten Lankhorst ]
* add 233-xf86events-valgrind. patch to fix a xserver corruption
when acpid is stopped before Xorg is. (LP: #1070481)
* add 235-composite-tracking. diff to fix exa corruption. (LP: #1010794) [ Bryce Harrington ]
* Add 236-use-fbdev-for- poulsbo- oaktrail- medfield. patch: Never use Intel
driver on Poulsbo/Oaktrail/ Medfield. Thanks to Matthias Klumpp.
(LP: #1069031)
* Add 237-dix-set-the- device- transformation- matrix. patch: Fix pointer
jumping with absolute pointing device. Initializes device
transformation matrix to an identity matrix. Thanks to a7x.
(LP: #1041063)
Hi Benjamin, thanks for packaging this patch and preparing the SRU. A few things need fixed though:
1. You applied the patch to the source, but instead it should be put into the debian/patches directory, and the patch name listed in debian/ patches/ series.
2. For quantal's xserver, our policy is to number patches consecutively. So you need to rename the patch, to 238-dix- fix-zaphod- screen- crossing. patch
3. In the bug report SRU, for regression potential you should elaborate more. Why might it get stuck on the second screen? There's no indication in the upstream bug report that this is possible.
4. You need a test case in the SRU as well. (Should be pretty simple.) Btw, have you reproduced the bug yourself on your own hardware? If so, that will make the SRU easier to verify - otherwise we need to find someone on quantal who can do the verification.