Merge lp:~bjornt/meta-lp-deps/windmill-headless into lp:meta-lp-deps

Proposed by Björn Tillenius
Status: Merged
Approved by: Max Bowsher
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~bjornt/meta-lp-deps/windmill-headless
Merge into: lp:meta-lp-deps
Diff against target: 29 lines (+10/-1)
2 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
To merge this branch: bzr merge lp:~bjornt/meta-lp-deps/windmill-headless
Reviewer Review Type Date Requested Status
Max Bowsher (community) Approve
Launchpad code reviewers Pending
Review via email: mp+15749@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Björn Tillenius (bjornt) wrote :

Depend on xvfb, firefox, and xfonts-base to make Windmill runnable in headless mode.

Revision history for this message
Max Bowsher (maxb) wrote :

<maxb> BjornT_: Hardy, of course, only has Firefox 2... is that adequate?
<BjornT_> maxb: yes, that's fine. i'm quite sure that's what the jscheck buildbot slave is using when running the windmill tests.
<maxb> In that case, amend the changelog to mention which of the three packages you are adding the dependencies to, and r=me

review: Approve
66. By Björn Tillenius

Mention that the dependencies are added to launchpad-developer-dependencies only.

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Mon, Dec 07, 2009 at 01:10:10PM -0000, Max Bowsher wrote:
> Review: Approve
> <maxb> BjornT_: Hardy, of course, only has Firefox 2... is that adequate?
> <BjornT_> maxb: yes, that's fine. i'm quite sure that's what the
> jscheck buildbot slave is using when running the windmill tests.
> <maxb> In that case, amend the changelog to mention which of the three
> packages you are adding the dependencies to, and r=me

Thanks! I've amended the changelog to mention that these dependencies
were added to launchpad-developer-dependencies.

--
Björn Tillenius | https://launchpad.net/~bjornt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-11-19 23:12:45 +0000
3+++ debian/changelog 2009-12-07 13:26:11 +0000
4@@ -1,3 +1,11 @@
5+launchpad-dependencies (0.59) karmic; urgency=low
6+
7+ * Depend on xvfb, firefox, and xfonts-base in
8+ launchpad-developers-dependencies, to make Windmill runnable in
9+ headless mode.
10+
11+ -- Bjorn Tillenius <bjorn@canonical.com> Mon, 07 Dec 2009 15:23:16 +0200
12+
13 launchpad-dependencies (0.58) hardy; urgency=low
14
15 * Depend on 2.5 packages, not 2.4 ones.
16
17=== modified file 'debian/control'
18--- debian/control 2009-11-19 23:11:52 +0000
19+++ debian/control 2009-12-07 13:26:11 +0000
20@@ -32,7 +32,8 @@
21 exuberant-ctags, bzr-pqm, python-pullparser, python-clientcookie,
22 postgresql-doc-8.3, postgresql-autodoc, tidy,
23 python-codespeak-lib, pylint, ssh, mhonarc,
24- fakeroot, rsync, spidermonkey-bin, git-core, memcached
25+ fakeroot, rsync, spidermonkey-bin, git-core, memcached,
26+ xvfb, firefox, xfonts-base
27 Recommends: pyflakes
28 Suggests: apache2
29 Description: Metapackage for dependencies of Launchpad

Subscribers

People subscribed via source and target branches