Merge ~bjornt/maas:bug-2073731-hotfix into maas:branch-3.4.3-hotfix-bug-2073731

[Björn Tillenius]

fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Some BMCs (like HPE ILO 5 3.05) seems to not report all the ciphers
that actually are enabled.

Instead of failing commissioning, we now only print out a warning.

Resolves LP:2073731

[Björn Tillenius (bjornt)]

Self-approve, so we can get this tested quickly.

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b bug-2073731-hotfix lp:~bjornt/maas/+git/maas into -b branch-3.4.3-hotfix-bug-2073731 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/6135/console

[Jerzy Husakowski (jhusakowski)]

review: Approve

[Jack Lloyd-Walters (lloydwaltersj)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b bug-2073731-hotfix lp:~bjornt/maas/+git/maas into -b branch-3.4.3-hotfix-bug-2073731 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/6137/console
COMMIT: b4d06ee779fafcdb8c1d69e1809067ff594b00b1

review: Needs Fixing

[Jack Lloyd-Walters (lloydwaltersj)]

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b bug-2073731-hotfix lp:~bjornt/maas/+git/maas into -b branch-3.4.3-hotfix-bug-2073731 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/6139/console

[Jack Lloyd-Walters (lloydwaltersj)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b bug-2073731-hotfix lp:~bjornt/maas/+git/maas into -b branch-3.4.3-hotfix-bug-2073731 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/6141/console
COMMIT: b4d06ee779fafcdb8c1d69e1809067ff594b00b1

review: Needs Fixing

375b1f4... by Björn Tillenius on 2024-07-26

test: fix intermitten test_Commission_starts_commissioning failure

The test assumed a certain ordering of the ids, but relied
on postgres default ordering.

diff --git a/src/maasserver/tests/test_node_action.py b/src/maasserver/tests/test_node_action.py
index 4593e3b..1ac9f14 100644
--- a/src/maasserver/tests/test_node_action.py
+++ b/src/maasserver/tests/test_node_action.py
@@ -396,7 +396,7 @@ class TestCommissionAction(MAASServerTestCase):
             action.execute(
                 testing_scripts=testing_scripts, script_input=script_input
             )
-        script_sets = ScriptSet.objects.all()
+        script_sets = ScriptSet.objects.all().order_by("id")
         node = reload_object(node)
         self.assertEqual(2, len(script_sets))
         self.assertEqual(
diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
index cfaa80d..cea099f 100755
--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
@@ -553,8 +553,10 @@ class IPMI(IPMIBase):
         # this one.
 
         if not self._check_ciphers_enabled():
-            print("ERROR: No cipher enabled!", file=sys.stderr)
-            sys.exit(1)
+            # We can't detect any suitable cipher. We still continue,
+            # since we don't trust that the BMC reports all the
+            # ciphers that actually are usable.
+            print("WARNING: No cipher enabled!", file=sys.stderr)
 
         self._config_ipmi_lan_channel_settings()
         self._config_lan_conf_auth()