Merge lp:~bjornt/launchpad/dont-hardcode-auto-generated-names into lp:launchpad

Proposed by Björn Tillenius on 2010-05-18
Status: Merged
Approved by: Graham Binns on 2010-05-18
Approved revision: no longer in the source branch.
Merged at revision: 10878
Proposed branch: lp:~bjornt/launchpad/dont-hardcode-auto-generated-names
Merge into: lp:launchpad
Diff against target: 24 lines (+2/-2)
2 files modified
lib/lp/bugs/doc/bugnotification-sending.txt (+1/-1)
lib/lp/translations/tests/test_shared_potemplate.py (+1/-1)
To merge this branch: bzr merge lp:~bjornt/launchpad/dont-hardcode-auto-generated-names
Reviewer Review Type Date Requested Status
Graham Binns (community) code 2010-05-18 Approve on 2010-05-18
Review via email: mp+25518@code.launchpad.net

Description of the Change

Change some tests not to depend on getUniqueInteger() and
getUniqueString() to return certain values.

This branch is in preparation for changing how getUniqueString()
generates the string.

To post a comment you must log in.
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/doc/bugnotification-sending.txt'
2--- lib/lp/bugs/doc/bugnotification-sending.txt 2010-04-16 05:03:03 +0000
3+++ lib/lp/bugs/doc/bugnotification-sending.txt 2010-05-18 14:16:34 +0000
4@@ -1410,7 +1410,7 @@
5 desc
6 <BLANKLINE>
7 To unsubscribe from this bug, go to:
8- http://bugs.launchpad.dev/product-name4/+bug/.../+subscribe
9+ http://bugs.launchpad.dev/.../+bug/.../+subscribe
10 <BLANKLINE>
11 ----------------------------------------------------------------------
12
13
14=== modified file 'lib/lp/translations/tests/test_shared_potemplate.py'
15--- lib/lp/translations/tests/test_shared_potemplate.py 2009-10-23 16:29:27 +0000
16+++ lib/lp/translations/tests/test_shared_potemplate.py 2010-05-18 14:16:34 +0000
17@@ -62,7 +62,7 @@
18 self.assertEquals(potmsgset, read_potmsgset)
19
20 def test_getPOTMsgSetBySequence(self):
21- sequence = self.factory.getUniqueInteger()
22+ sequence = 2
23 potmsgset = self.factory.makePOTMsgSet(self.devel_potemplate,
24 sequence=sequence)
25