Merge lp:~bjornt/launchpad/choiceedit-click-handler into lp:launchpad/db-devel

[Björn Tillenius]

[Björn Tillenius (bjornt)]

Fix "Target to milestone" on the bug page to work inline again.

A change in lazr-js fixed some issues with the ChoiceEdit, making it
work in Opera. However, when LP was changed to use this newer lazr-js
version, the code that set up the "Target to milestone" link wasn't
updated, causing the code to break, since it tried calling and old
method that doesn't exist anymore.

I would normally write a Windmill test for this (which would have
caught this error earlier), but Tom is already writing tests for the
bug task table (bug 488142).

--
Björn Tillenius | https://launchpad.net/~bjornt

[Graham Binns (gmb)]

review: Approve (js)

[Guilherme Salgado (salgado)]

Looks good, but please double check that there are no other callsites that use _onMouseDown.

review: Approve (release-critical)

[Björn Tillenius (bjornt)]

On Tue, Dec 01, 2009 at 12:43:48PM -0000, Guilherme Salgado wrote:
> Review: Approve release-critical
> Looks good, but please double check that there are no other callsites
> that use _onMouseDown.

grep doesn't find "onMouseDown" in either lib/lp or lib/canonical.

=== modified file 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js'
--- lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-11-24 09:30:01 +0000
+++ lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-12-01 12:20:31 +0000
@@ -1465,8 +1465,8 @@
             milestone_choice_edit._uiClearWaiting();
         });
         milestone_content.one('.nulltext').on(
-            'mousedown',
-            milestone_choice_edit._onMouseDown,
+            'click',
+            milestone_choice_edit.onClick,
             milestone_choice_edit);
         milestone_choice_edit.render();
     }