Merge lp:~bjornt/landscape-client/update-package-profile-repo into lp:~landscape/landscape-client/trunk

[Björn Tillenius]

Make sure package profiles get added to the facade cache, before trying
to install them.

Before, if the change-packages message contained binaries, they would be
added to the repo on disk, but the facade didn't reread the Packages
file, so when trying to install the binary it couldn't find it, thus
needing to wait for the reporter to update the package information.

I've made it possible to force a re-read of the Packages file. Ideally
we would update only our internal repo, but since the API for updating a
single source.list file isn't available in Lucid, I went for updating
everything for now. We can make it more efficient later.

I also changed the semantics of ensure_channels_reloaded(), so that it
won't reload if reload_channels() has been called already, to avoid
having the change-packages handler reload the channels twice.

[Thomas Herve (therve)]

Looks great, +1. Maybe you can link the bug opened with a XXX.

review: Approve

[lp:~bjornt/landscape-client/update-package-profile-repo]

514. By Björn Tillenius on 2012-03-14

No need to create a new facade.

[Free Ekanayaka (free.ekanayaka)]

Looks good! +1

[1]

+ new_facade = AptFacade(root=self.apt_root)

As discussed on IRC, it seems there's no need to create a new facade object, which makes the test a bit confusing to me at least.

review: Approve

[lp:~bjornt/landscape-client/update-package-profile-repo]

515. By Björn Tillenius on 2012-03-14

Add XXX.

516. By Björn Tillenius on 2012-03-14

Reload the channels to make test pass.