Merge lp:~bjornt/landscape-client/update-internal-repos-only into lp:~landscape/landscape-client/trunk

Proposed by Björn Tillenius
Status: Merged
Approved by: Geoff Teale
Approved revision: 533
Merged at revision: 534
Proposed branch: lp:~bjornt/landscape-client/update-internal-repos-only
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~bjornt/landscape-client/update-internal-repos-only
Reviewer Review Type Date Requested Status
Geoff Teale (community) Approve
Thomas Herve (community) Approve
Review via email:

Description of the change

Update only internal facade repositories in AptFacade.reload_channels()
if force_reload_binaries is specified. That is, only repositories listed
in the facade-specific .list file will be updated, other repositories in
sources.list and sources.list.d won't.

This will only work if python-apt is new enough. For older version
(e.g. on Lucid) everything will still be updated. There doesn't seem to
be a better way of determining whether python-apt is new enough apart
from trying to call the update() method.

I do think the parameter name force_reload_binaries could be improved. I
filed bug 960217 about moving the refetch_package_index to be a
parameter to update() and I will rethink the names then.

To post a comment you must log in.
Revision history for this message
Thomas Herve (therve) wrote :

[1] pyflakes:

landscape/package/ 'time' imported but unused

Looks great, +1!

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

+1 Approve.

review: Approve
534. By Björn Tillenius

Merge trunk.

535. By Björn Tillenius

Fix lint.

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Wed, Mar 21, 2012 at 08:01:43AM -0000, Thomas Herve wrote:
> Review: Approve
> [1] pyflakes:
> landscape/package/ 'time' imported but unused

It's in trunk actually, but still my fault :) I've fixed it.

Preview Diff



People subscribed via source and target branches

to all changes: