Landscape Client

Merge lp:~bjornt/landscape-client/dpkg-path into lp:~landscape/landscape-client/trunk

  1. dpkg-path
  2. Merge into trunk
Proposed by Björn Tillenius
Status: Merged
Merged at revision: 537
Proposed branch: lp:~bjornt/landscape-client/dpkg-path
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~bjornt/landscape-client/dpkg-path
Reviewer Review Type Date Requested Status
Christopher Armstrong (community) Approve
Fernando Correa Neto (community) Approve
Review via email: mp+98699@code.launchpad.net

Description of the change

Set PATH before doing package operation, since dpkg will fail if PATH
isn't set.

PATH is normally set, but it isn't set if the client is started by the
settings UI.

To post a comment you must log in.
Revision history for this message
Fernando Correa Neto (fcorrea) wrote :

Looks good, +1!

review: Approve
Revision history for this message
Christopher Armstrong (radix) wrote :

Looks good, +1. I am slightly concerned about other subprocesses that may have the same problem; I noticed that we also run apt-key as a subprocess, and maybe it relies on having a PATH set. I think we should test that, but this branch can be merged now regardless since it is purely an improvement.

review: Approve
lp:~bjornt/landscape-client/dpkg-path updated
538. By Björn Tillenius

Set PATH in init script to make sure it's always set.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: