Merge ~binli/ubuntu/+source/gdm3:bionic into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic

Proposed by Bin Li
Status: Rejected
Rejected by: Iain Lane
Proposed branch: ~binli/ubuntu/+source/gdm3:bionic
Merge into: ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic
Diff against target: 35 lines (+4/-2)
3 files modified
data/61-gdm.rules.in (+2/-0)
data/Makefile.am (+1/-1)
debian/gdm3.install (+1/-1)
Reviewer Review Type Date Requested Status
Iain Lane Needs Fixing
Review via email: mp+354839@code.launchpad.net

Commit message

commit 287fe76d874f02c568a1c36660f00e7eb14f70e0 (HEAD -> bionic, binli/bionic)
Author: Bin Li <email address hidden>
Date: Thu Sep 13 15:38:35 2018 +0800

    debian/gdm3.install:
    - install udev rules in the correct folder (following upstream build
      fixes)

commit dd0547c1176bd3e782154483a2f42237b41d039f
Author: Bin Li <email address hidden>
Date: Wed Aug 29 16:47:46 2018 +0800

    data: 61-gdm.rules.in

    Disable wayland for Huawei Hi1710 chipsets.

    The login screen is skewed/distorted on arm server, and I couldn't
    find root cause, and no other developer ever has access to the hardware.

    https://gitlab.gnome.org/GNOME/mutter/issues/219

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks. These need to be shipped as Debian patches though.

https://wiki.ubuntu.com/DesktopTeam/git#Pick_some_upstream_commits

(you can use 'import' instead of 'rebase' if you don't have a patch queue branch already)

After importing, I'd prefer it if you could please "git rebase -i ubuntu/bionic" and put your new commits above the Ubuntu/Debian ones.

And please edit the commit messages so that they contain information about where the patches come from (https://dep-team.pages.debian.net/deps/dep3/ - we'd at least want Bug-Ubuntu, Bug and Origin).

review: Needs Fixing
Revision history for this message
Bin Li (binli) wrote :

@Iain,

Follow the tips, I pushed a new branch, could you help me check it? Thanks!

https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933

Revision history for this message
Iain Lane (laney) wrote :

ok, let's head over there, thanks

Unmerged commits

ad04e1b... by Bin Li

data: Makefile.am

The $prefix was /usr in general, but rules in /usr/lib/udev/ can't
be loaded by udev, so just remove it.

287fe76... by Bin Li

debian/gdm3.install:
- install udev rules in the correct folder (following upstream build
  fixes)

dd0547c... by Bin Li

data: 61-gdm.rules.in

Disable wayland for Huawei Hi1710 chipsets.

The login screen is skewed/distorted on arm server, and I couldn't
find root cause, and no other developer ever has access to the hardware.

https://gitlab.gnome.org/GNOME/mutter/issues/219

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/data/61-gdm.rules.in b/data/61-gdm.rules.in
2index de8e179..c9f6110 100644
3--- a/data/61-gdm.rules.in
4+++ b/data/61-gdm.rules.in
5@@ -1,2 +1,4 @@
6 # disable Wayland on Cirrus chipsets
7 ATTR{vendor}=="0x1013", ATTR{device}=="0x00b8", ATTR{subsystem_vendor}=="0x1af4", ATTR{subsystem_device}=="0x1100", RUN+="@libexecdir@/gdm-disable-wayland"
8+# disable Wayland on Hi1710 chipsets
9+ATTR{vendor}=="0x19e5", ATTR{device}=="0x1711", RUN+="@libexecdir@/gdm-disable-wayland"
10diff --git a/data/Makefile.am b/data/Makefile.am
11index 192dfa0..e008ed1 100644
12--- a/data/Makefile.am
13+++ b/data/Makefile.am
14@@ -158,7 +158,7 @@ if ENABLE_ARCH_PAM_CONFIG
15 pam_files = $(pam_arch_files)
16 endif
17
18-udevrulesdir = $(prefix)/lib/udev/rules.d
19+udevrulesdir = /lib/udev/rules.d
20 udevrules_DATA = 61-gdm.rules
21
22 EXTRA_DIST += $(srcdir)/61-gdm.rules.in
23diff --git a/debian/gdm3.install b/debian/gdm3.install
24index c69747c..b7438b8 100644
25--- a/debian/gdm3.install
26+++ b/debian/gdm3.install
27@@ -3,7 +3,7 @@ lib/systemd/
28 lib/*/security/*.so
29 usr/bin/gdm-screenshot
30 usr/lib/gdm3/gdm-*
31-usr/lib/udev
32+lib/udev
33 # gets renamed to gdm3 in binary-install
34 usr/sbin/gdm
35 usr/share/pixmaps/

Subscribers

People subscribed via source and target branches

to all changes: