~bind-charmers/charm-k8s-bind/+git/charmcraft-review:review

Branch merges

Propose for merging

Merged into ~bind-charmers/charm-k8s-bind/+git/charmcraft-review:master at revision 8616c50ee14acbcd2292ab0324aaed870e8e7a08

Facundo Batista (community): Approve on 2020-10-06

Barry Price: Needs Resubmitting on 2020-10-01

Diff: 745 lines (+551/-86)

13 files modified

.jujuignore (+7/-3)
Makefile (+46/-0)
README.md (+44/-16)
config.yaml (+44/-8)
dev/null (+0/-36)
dockerfile (+33/-0)
image-scripts/dns-check.sh (+10/-0)
image-scripts/docker-entrypoint.sh (+23/-0)
pyproject.toml (+3/-0)
src/charm.py (+124/-23)
tests/unit/requirements.txt (+4/-0)
tests/unit/test_charm.py (+167/-0)
tox.ini (+46/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

8616c50... by Barry Price on 2020-10-01

Address review comments, and drop the io import since we no longer use it

0188896... by Barry Price on 2020-09-25

Address charmcraft review

e253a2e... by Tom Haddon on 2020-08-29

Copied from main project for review

8141d30... by Tom Haddon on 2020-08-29

Remove license file as we have licence

dcf9dd3... by Tom Haddon on 2020-08-29

Initial commit from charmcraft init plus copyright and licence