Merge lp:~billy-olsen/horizon/icehouse-fix-lp1476417 into lp:~ubuntu-server-dev/horizon/icehouse

Proposed by Billy Olsen
Status: Merged
Merged at revision: 204
Proposed branch: lp:~billy-olsen/horizon/icehouse-fix-lp1476417
Merge into: lp:~ubuntu-server-dev/horizon/icehouse
Diff against target: 68 lines (+48/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/fix-neutron-connection-error.patch (+38/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~billy-olsen/horizon/icehouse-fix-lp1476417
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+266045@code.launchpad.net

Description of the change

Remove the invocation to the FloatingIPManager.is_supported() method when retrieving floating IP addresses. The full integration of FloatingIPManager.is_supported() was introduced as a blueprint/new feature in the Juno release and the backport should not have contained this portion of the fix.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-06-23 13:29:00 +0000
3+++ debian/changelog 2015-07-27 21:55:06 +0000
4@@ -1,3 +1,12 @@
5+horizon (1:2014.1.5-0ubuntu2) trusty; urgency=medium
6+
7+ * Fix "Unable to Connect to Neutron" error message which is displayed
8+ in various UI panels. (LP: #1476417)
9+ - d/p/fix-neutron-connection-error.patch - Removes the erroneous
10+ usage of the FloatingIPManager.is_supported() method.
11+
12+ -- Billy Olsen <billy.olsen@canonical.com> Mon, 27 Jul 2015 10:37:15 -0700
13+
14 horizon (1:2014.1.5-0ubuntu1) trusty; urgency=medium
15
16 * Resynchronize with stable/icehouse (4ff165c) (LP: #1467533):
17
18=== added file 'debian/patches/fix-neutron-connection-error.patch'
19--- debian/patches/fix-neutron-connection-error.patch 1970-01-01 00:00:00 +0000
20+++ debian/patches/fix-neutron-connection-error.patch 2015-07-27 21:55:06 +0000
21@@ -0,0 +1,38 @@
22+From 55ca4a0bee79d1ba660a1d52bcfa4660e44cb23c Mon Sep 17 00:00:00 2001
23+From: Billy Olsen <billy.olsen@canonical.com>
24+Date: Fri, 24 Jul 2015 16:30:46 -0700
25+Subject: [PATCH 1/1] Fix "Unable to Connect to Neutron" error.
26+
27+Remove the check for FloatingIpManager.is_supported() in neutron.py when
28+returning a list of floating IPs. The FloatingIpManager.is_supported method
29+was part of the blueprint to hide floating IP information when a network is
30+in use which doesn't support floating IPs.
31+
32+Closes-Bug: #1476417
33+---
34+ openstack_dashboard/api/neutron.py | 9 +++------
35+ 1 file changed, 3 insertions(+), 6 deletions(-)
36+
37+diff --git a/openstack_dashboard/api/neutron.py b/openstack_dashboard/api/neutron.py
38+index ddbd0af..d21ae9b 100644
39+--- a/openstack_dashboard/api/neutron.py
40++++ b/openstack_dashboard/api/neutron.py
41+@@ -815,12 +815,9 @@ def servers_update_addresses(request, servers, all_tenants=False):
42+ port_list, 'device_id', [instance.id for instance in servers],
43+ request=request)
44+ fips = FloatingIpManager(request)
45+- if fips.is_supported():
46+- floating_ips = list_resources_with_long_filters(
47+- fips.list, 'port_id', [port.id for port in ports],
48+- all_tenants=all_tenants)
49+- else:
50+- floating_ips = []
51++ floating_ips = list_resources_with_long_filters(
52++ fips.list, 'port_id', [port.id for port in ports],
53++ all_tenants=all_tenants)
54+ networks = list_resources_with_long_filters(
55+ network_list, 'id', set([port.network_id for port in ports]),
56+ request=request)
57+--
58+2.1.4
59+
60
61=== modified file 'debian/patches/series'
62--- debian/patches/series 2015-06-22 15:27:31 +0000
63+++ debian/patches/series 2015-07-27 21:55:06 +0000
64@@ -7,3 +7,4 @@
65 #fix-ubuntu-tests.patch
66 ubuntu_settings.patch
67 fix-requirements.patch
68+fix-neutron-connection-error.patch

Subscribers

People subscribed via source and target branches