lp:~billy-olsen/charm-helpers/better-address-endpoint-overrides

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charm-helpers at revision 383

Jorge Niedbalski (community): Approve on 2015-06-04

Felipe Reyes: Pending requested 2015-06-03

charmers: Pending requested 2015-06-03

Edward Hope-Morley: Pending requested 2015-06-03

Diff: 224 lines (+75/-73)

2 files modified

charmhelpers/contrib/openstack/ip.py (+49/-44)
tests/contrib/openstack/test_ip.py (+26/-29)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1398182: Charms need config option to set public endpoint address

Medium

Fix Released

Link a bug report

Related blueprints

388. By Billy Olsen on 2015-06-04

Per niedbalski's review remove jinja2 dependency and use simple string
formatting. Additionally break out the override check into its own
function.

387. By Billy Olsen on 2015-06-04

Add templating to the os-public-hostname override per jjo's bug comment.

386. By Billy Olsen on 2015-06-03

Switch config option to os-public-hostname

385. By Billy Olsen on 2015-06-02

Allow configs to be None and default to http if it isn't found
for the protocol scheme

384. By Billy Olsen on 2015-06-02

Move public address override into resolve_address.

383. By Billy Olsen on 2015-05-29

After studying the code across the OpenStack charms, it seems a better
place for the override is to place it in the canonical_url method. This
has the advantage of capturing more places besides endpoint URLs (e.g.
also for console hosts etc) and requires fewer changes to most of the
OpenStack charms.

382. By Billy Olsen on 2015-05-29

[wolsen,r=] Change contrib.openstack.ip endpoint functions to specify an
override of an address rather than the endpoint value itself.

This change makes it easier to use since users will only need to specify
a single public-addres, internal-address, or admin-address on a charm and
it can apply to all endpoints created by a charm.

This method is safe to alter the actual behavior of the method rather than
honoring the legacy behavior since it is not used by any of the openstack
charms to date as the one merge including it has been withdrawn in favor
of using a simpler approach.

381. By Chris Glass on 2015-05-29

Merge lp:~free.ekanayaka/charm-helpers/relation-set-file. [a=free.ekayanaka] [r=tribaal]

This branch fixes the related bug and reintroduces the --file feature of relation-set.

380. By James Page on 2015-05-27

OpenStack deploy-from-source

* Default to shallow clone for git (depth=1)
* Add Python virtualenv support for pip installs
* Pass http_proxy to pip install if specified

379. By James Page on 2015-05-27

Reverting commit 373 due to regressions in hacluster charm relation.