lp:~billy-olsen/charm-helpers/better-address-endpoint-overrides
- Get this branch:
- bzr branch lp:~billy-olsen/charm-helpers/better-address-endpoint-overrides
Branch merges
- Jorge Niedbalski (community): Approve
- Felipe Reyes: Pending requested
- charmers: Pending requested
- Edward Hope-Morley: Pending requested
-
Diff: 224 lines (+75/-73)2 files modifiedcharmhelpers/contrib/openstack/ip.py (+49/-44)
tests/contrib/openstack/test_ip.py (+26/-29)
Related bugs
Bug #1398182: Charms need config option to set public endpoint address | Medium | Fix Released |
Related blueprints
Branch information
Recent revisions
- 388. By Billy Olsen
-
Per niedbalski's review remove jinja2 dependency and use simple string
formatting. Additionally break out the override check into its own
function. - 385. By Billy Olsen
-
Allow configs to be None and default to http if it isn't found
for the protocol scheme - 383. By Billy Olsen
-
After studying the code across the OpenStack charms, it seems a better
place for the override is to place it in the canonical_url method. This
has the advantage of capturing more places besides endpoint URLs (e.g.
also for console hosts etc) and requires fewer changes to most of the
OpenStack charms. - 382. By Billy Olsen
-
[wolsen,r=] Change contrib.
openstack. ip endpoint functions to specify an
override of an address rather than the endpoint value itself.This change makes it easier to use since users will only need to specify
a single public-addres, internal-address, or admin-address on a charm and
it can apply to all endpoints created by a charm.This method is safe to alter the actual behavior of the method rather than
honoring the legacy behavior since it is not used by any of the openstack
charms to date as the one merge including it has been withdrawn in favor
of using a simpler approach. - 381. By Chris Glass
-
Merge lp:~free.ekanayaka/charm-helpers/relation-set-file. [a=free.ekayanaka] [r=tribaal]
This branch fixes the related bug and reintroduces the --file feature of relation-set.
- 380. By James Page
-
OpenStack deploy-from-source
* Default to shallow clone for git (depth=1)
* Add Python virtualenv support for pip installs
* Pass http_proxy to pip install if specified
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:charm-helpers